Revert "Improve shortcut key reporting (#14900)"#15237
Merged
Merged
Conversation
seanbudd
approved these changes
Aug 1, 2023
See test results for failed build of commit ebb246b8c7 |
6 tasks
CyrilleB79
added a commit
to CyrilleB79/nvda
that referenced
this pull request
Sep 5, 2023
…ccess#15237)" This reverts commit e15fe8a.
6 tasks
CyrilleB79
added a commit
to CyrilleB79/nvda
that referenced
this pull request
Sep 5, 2023
…ccess#15237)" This reverts commit e15fe8a.
seanbudd
pushed a commit
that referenced
this pull request
Sep 6, 2023
Fixes #10807 Reintroduce the changes of PR #14900 that were reverted in #15237. Summary of the issue: See #14900 for the initial issue. #14900 had to be reverted since it caused any speech sequence containing a character mode command to spell the whole speech sequence with Code Factory driver. Although the issue is in the driver and not NVDA, it has been decided to wait for an API-breaking release to issue this fix so that Code Factory synth users be not impacted by this bug. Description of user facing changes Same as #14900, that is: Shortcut key reporting will be improved in some cases. This applies to on-demand reporting (shift+numpad2) as well as when "Report Object Shortcut Keys" option is checked in Object presentation settings. The cases where it should be improved are: punctuation key, e.g. "." (dot) letter keys when the name of the letter is not spoken the same way as the equivalent one-letter word, e.g. "à" or "y" in French. Braille reporting should remain unchanged. Description of development approach Revert #15237 to reintroduce the changes in #14900 and remove change log modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e6612e9.
Link to issue number:
Fixes #15233
Summary of the issue:
Unfortunately pr #14900 causes Code Factory Eloquence to spell out menu items with shortcut keys, such as in the NVDA menu.
Description of user facing changes
Menu items are no longer spelled out when focusing menu items when using the Code Factory Eloquence driver.
Description of development approach
Although the bug is technically in the Code Factory driver I think - not handlin character mode command correctly when embedded in other speech,
PR 14900 is the first known case that exercises the bug directly.
Because 2023.2 is not an add-on breaking release, we are reverting pr #14900.
A replacement pr for 2023.3 can be opened that avoids affecting Code Factory Eloquence if at all possible, or a new copy of the reverted pr can be opened for NVDA 2024.1.
Testing strategy:
Known issues with pull request:
None known.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: