Conversation
Fix-up of #15065 Summary of the issue: Various issues found in documentation while reviewing translation: Flattened review: For example, if you move to the next object in this flattened view and the current object contains other objects, NVDA will automatically move to the first object that contains it. Should be "that it contains", not "that contains it"! Cc @LeonarddeR for approval Excel UIA option not at the correct place in the documentation with respect to its position in the GUI's Advanced settings panel. Searching for add-ons -Type a keyword or two for the kind of add-on you're looking for, then tab back to the list of add-ons. Actually, we tab forward, not back. Add-on Store spelling: Let's take care to use an unique writing so that people get immediately used: So "Add-on Store", not "Add-ons Store". Key name formatting: Key name formatting should always be used for single keys, not for a whole list of keys including separators or parenthesis that do not belong to the name of a key as done for some braille keys.
…key (#15266) Fixes #15258 Summary of the issue: The add-on store has 2 sets of strings which are identical, except the inclusion of the an accelerator key. The add-on tabs (e.g. "Available add-ons") do not have an accelerator key, as they are navigated with control+tab. The add-on list is labelled as "Available &add-ons" so the list can easily be reached with alt+a. Previously, NVDA stripped the ampersand, and otherwise used the same translation strings. For Chinese, the method of stripping the accelerator key ampersand is not ideal. For example, translating "Updatable &add-ons" into Simplified Chinese is "可更新的插件(&A)". For the add-on tabs, this becomes "可更新的插件(A)" where it should be "可更新的插件". Description of user facing changes Translation strings are now separate, allowing Chinese translators to translate the strings as "可更新的插件(&A)" and "可更新的插件" Description of development approach Translation strings are now separate, allowing Chinese translators to translate the strings as "可更新的插件(&A)" and "可更新的插件" Testing strategy: Test viewing the tabs in NVDA and using the accelerator keys
Raised in #15246 (comment) Summary of the issue: Sometimes a custom modal dialog is required, instead of just using gui.message.messageBox. For example, adding additional buttons or controls instead of just message text and ok/cancel/yes/no buttons. However gui.message.messageBox adds special handling to ensure users are warned if actions are blocked by an open modal dialog. Description of user facing changes Users are warned when trying to perform a task (e.g opening the NVDA menu) when modal dialogs from the add-on store are waiting a response. Other modal dialogs have also been addressed, unless they are non-blocking (i.e. started in a separate thread). These might be worth addressing too, on a case-by-case basis. Description of development approach Create a helper function to show a dialog as a modal dialog, while performing the necessary handling of messageBox Testing strategy: Test opening various Add-on store dialogs and performing nvda+n
See test results for failed build of commit d1662c5a4b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.