Skip to content

Add-on store: use separate translation strings for the status filter key#15266

Merged
seanbudd merged 1 commit into
betafrom
splitTranslatorStringsUp
Aug 7, 2023
Merged

Add-on store: use separate translation strings for the status filter key#15266
seanbudd merged 1 commit into
betafrom
splitTranslatorStringsUp

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 7, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixes #15258

Summary of the issue:

The add-on store has 2 sets of strings which are identical, except the inclusion of the an accelerator key.
The add-on tabs (e.g. "Available add-ons") do not have an accelerator key, as they are navigated with control+tab.
The add-on list is labelled as "Available &add-ons" so the list can easily be reached with alt+a.
Previously, NVDA stripped the ampersand, and otherwise used the same translation strings.
For Chinese, the method of stripping the accelerator key ampersand is not ideal.
For example, translating "Updatable &add-ons" into Simplified Chinese is "可更新的插件(&A)".
For the add-on tabs, this becomes "可更新的插件(A)" where it should be "可更新的插件".

Description of user facing changes

Translation strings are now separate, allowing Chinese translators to translate the strings as "可更新的插件(&A)" and "可更新的插件"

Description of development approach

Translation strings are now separate, allowing Chinese translators to translate the strings as "可更新的插件(&A)" and "可更新的插件"

Testing strategy:

Test viewing the tabs in NVDA and using the accelerator keys

Known issues with pull request:

None

Change log entries:

N/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd added this to the 2023.2 milestone Aug 7, 2023
@seanbudd seanbudd requested a review from a team as a code owner August 7, 2023 01:30
@seanbudd seanbudd requested review from michaelDCurran and removed request for a team August 7, 2023 01:30
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 614fa64b2d

@seanbudd seanbudd merged commit b27be75 into beta Aug 7, 2023
@seanbudd seanbudd deleted the splitTranslatorStringsUp branch August 7, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants