Add-on store: use separate translation strings for the status filter key#15266
Merged
Conversation
See test results for failed build of commit 614fa64b2d |
michaelDCurran
approved these changes
Aug 7, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #15258
Summary of the issue:
The add-on store has 2 sets of strings which are identical, except the inclusion of the an accelerator key.
The add-on tabs (e.g. "Available add-ons") do not have an accelerator key, as they are navigated with
control+tab.The add-on list is labelled as "Available &add-ons" so the list can easily be reached with
alt+a.Previously, NVDA stripped the ampersand, and otherwise used the same translation strings.
For Chinese, the method of stripping the accelerator key ampersand is not ideal.
For example, translating "Updatable &add-ons" into Simplified Chinese is "可更新的插件(&A)".
For the add-on tabs, this becomes "可更新的插件(A)" where it should be "可更新的插件".
Description of user facing changes
Translation strings are now separate, allowing Chinese translators to translate the strings as "可更新的插件(&A)" and "可更新的插件"
Description of development approach
Translation strings are now separate, allowing Chinese translators to translate the strings as "可更新的插件(&A)" and "可更新的插件"
Testing strategy:
Test viewing the tabs in NVDA and using the accelerator keys
Known issues with pull request:
None
Change log entries:
N/a
Code Review Checklist: