Link to issue number:

Raised in #15246 (comment)

Summary of the issue:

Sometimes a custom modal dialog is required, instead of just using gui.message.messageBox.
For example, adding additional buttons or controls instead of just message text and ok/cancel/yes/no buttons.
However gui.message.messageBox adds special handling to ensure users are warned if actions are blocked by an open modal dialog.

Description of user facing changes

Users are warned when trying to perform a task (e.g opening the NVDA menu) when modal dialogs from the add-on store are waiting a response.
Other modal dialogs have also been addressed, unless they are non-blocking (i.e. started in a separate thread).
These might be worth addressing too, on a case-by-case basis.

Description of development approach

Create a helper function to show a dialog as a modal dialog, while performing the necessary handling of messageBox

Testing strategy:

Test opening various Add-on store dialogs and performing nvda+n

Known issues with pull request:

There are other dialogs in NVDA with this problem, however most are addressed in this PR.

Change log entries:

N/A

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.