Skip to content

merge beta to master#15247

Merged
seanbudd merged 1 commit into
masterfrom
beta
Aug 2, 2023
Merged

merge beta to master#15247
seanbudd merged 1 commit into
masterfrom
beta

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 2, 2023

Copy link
Copy Markdown
Member

merge beta to master

Closes #15231

Summary of the issue:
If NVDA language is set to Serbian, the cache could get corrupted while reading or writing do to the encoding not specified while opening the file.

Description of user facing changes
NVDA add-on store works with Serbian. Also, If the cached installed addon data is invalid, the exception will be logged similar to the add-on store cache, instead of preventing the add-on store from launching.

Description of development approach
open all files in _addonStore\dataManager.py in utf-8.
If the file is unable to be opened, or json.load fails, the exception will be logged.
Testing strategy:
Installed multiple add-ons, with Serbian translation and without, while NVDA's language is set to Serbian.
@seanbudd seanbudd requested a review from a team as a code owner August 2, 2023 05:15
@seanbudd seanbudd requested a review from michaelDCurran August 2, 2023 05:15
@seanbudd seanbudd merged commit 61f7119 into master Aug 2, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants