Conversation
Closes #15231 Summary of the issue: If NVDA language is set to Serbian, the cache could get corrupted while reading or writing do to the encoding not specified while opening the file. Description of user facing changes NVDA add-on store works with Serbian. Also, If the cached installed addon data is invalid, the exception will be logged similar to the add-on store cache, instead of preventing the add-on store from launching. Description of development approach open all files in _addonStore\dataManager.py in utf-8. If the file is unable to be opened, or json.load fails, the exception will be logged. Testing strategy: Installed multiple add-ons, with Serbian translation and without, while NVDA's language is set to Serbian.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge beta to master