Conversation
Fixup of #14924 Summary of the issue: In #14627, we introduced weak references for APCs called as part of a waitable timer. In #14924, this was made more robust by using a single internal APC func. However in the porting process, a part of the logic was reversed, therefore in the internal APC store, we still stored strong rather than weak references. Description of user facing changes None. Description of development approach Store references instead of functions in the apc store.
#13985 introduced new restrictions for temporary copies of NVDA, preventing the add-on store from opening and preventing writing to disk. These should be explained in the user guide Description of user facing changes N/A Description of development approach Simplified some of the structure in the user guide, including explaining what a temporary copy is.
Fixes #15218 Summary of the issue: Add-ons which were being installed from an external source were treated like an installed add-on. This resulted in trying to get manifest information for the installed add-ons collection, rather than the bundle that the install is coming from. When trying to install an incompatible add-on from an external source, an error is raised, as manifest data is not fetched correctly. This prevents the confirmation dialog from appearing and prevents the user from installing incompatible add-ons from external sources. Description of user facing changes Add-ons which are incompatible can be installed from an external source. Description of development approach Instead, use the manifest data from the external add-on bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.