Link to issue number:

Fixes #15218

Summary of the issue:

Add-ons which were being installed from an external source were treated like an installed add-on.
This resulted in trying to get manifest information for the installed add-ons collection, rather than the bundle that the install is coming from.
When trying to install an incompatible add-on from an external source, an error is raised, as manifest data is not fetched correctly.
This prevents the confirmation dialog from appearing and prevents the user from installing incompatible add-ons from external sources.

Description of user facing changes

Add-ons which are incompatible can be installed from an external source.

Description of development approach

Instead, use the manifest data from the external add-on bundle.

Testing strategy:

Manually test STR in #15218
Smoke test installing add-ons using the [manual test plan] (https://github.com/nvaccess/nvda/blob/master/tests/manual/addonStore.md)

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.