Skip to content

Fixup #14924: again use weak references for waitable timer functions#15215

Merged
seanbudd merged 1 commit into
nvaccess:betafrom
LeonarddeR:fixWeakRef
Jul 30, 2023
Merged

Fixup #14924: again use weak references for waitable timer functions#15215
seanbudd merged 1 commit into
nvaccess:betafrom
LeonarddeR:fixWeakRef

Conversation

@LeonarddeR

Copy link
Copy Markdown
Collaborator

Link to issue number:

Fixup of #14924

Summary of the issue:

In #14627, we introduced weak references for APCs called as part of a waitable timer. In #14924, this was made more robust by using a single internal APC func. However in the porting process, a part of the logic was reversed, therefore in the internal APC store, we still stored strong rather than weak references.

Description of user facing changes

None.

Description of development approach

Store references instead of functions in the apc store.

Testing strategy:

  • Ensure that ack packets are still properly handled on handy tech displays

Known issues with pull request:

None known

Change log entries:

None needed, introduced in 2023.2 dev cycle.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@LeonarddeR LeonarddeR requested a review from a team as a code owner July 29, 2023 11:45
@LeonarddeR LeonarddeR requested review from seanbudd and removed request for a team July 29, 2023 11:45
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit fec8429236

@seanbudd seanbudd merged commit 35c2d1d into nvaccess:beta Jul 30, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.3 milestone Jul 30, 2023
@seanbudd seanbudd modified the milestones: 2023.3, 2023.2 Jul 30, 2023
@LeonarddeR LeonarddeR deleted the fixWeakRef branch August 23, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants