Add-on store: support localisation for installed add-ons#15137
Merged
Conversation
michaelDCurran
approved these changes
Jul 13, 2023
michaelDCurran
approved these changes
Jul 14, 2023
Collaborator
In the installed add-ons tab, for example clipContentsDesigner 27.0.0 is not shown in Spanish, though a translated manifest.ini with a description in Spanish exists in the add-on. |
This was referenced Jul 17, 2023
seanbudd
added a commit
that referenced
this pull request
Jul 17, 2023
#15152) Closes #14973 Summary of the issue: Add-ons installed from the add-on store used the untranslated add-on store JSON strings. As of #15137, only add-ons that were installed from an external source had translated strings. Description of user facing changes Add-ons installed from the add-on store will have translated strings. Description of development approach Create a separate model for add-ons fetched from the add-on store, and add-ons cached after being installed from the add-on store. Data fetched from the add-on store should be translated. Installed cached data for an add-on will be whatever language is used when the fetched add-on store data is cached. As such, we should defer to the translated manifests for installed add-ons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Part of #14973
Summary of the issue:
Installed add-ons do not have their display name and description localised, even if localised manifests exist for the installed add-on.
Description of user facing changes
Reinstate localisation for installed add-ons of the display name and description
Description of development approach
Fetch translated strings from the localised manifests
Testing strategy:
Ensure add-on with localisations is correctly displayed in the installed add-ons tab of the store.
Available and updatable add-ons rely on the strings to be translated when fetching from the store.
Known issues with pull request:
Available add-ons are not localised:
This should be fixed by nvaccess/addon-datastore#1095
Change log entries:
N/A
Code Review Checklist: