Support translations: remove lang code from transform#1095
Merged
Conversation
michaelDCurran
approved these changes
Jul 14, 2023
seanbudd
added a commit
to nvaccess/addon-datastore-validation
that referenced
this pull request
Jul 14, 2023
Append all translations to the add-on submission when creating the JSON submission file from a downloaded add-on manifest. Adds a script to regenerate translations for all add-ons. Translations for displayName and description are append to the JSON submission file. These translations will be used for the transformation to views in a subsequent PR to `-transform`: - nvaccess/addon-datastore-transform#23 - nvaccess/addon-datastore#1095
seanbudd
added a commit
to nvaccess/addon-datastore-transform
that referenced
this pull request
Jul 14, 2023
Using translation data parsed by nvaccess/addon-datastore-validation#32, create translated views of each add-on Related PRs: - nvaccess/addon-datastore-validation#32 - nvaccess/addon-datastore#1095
seanbudd
added a commit
that referenced
this pull request
Mar 17, 2026
Using translation data parsed by nvaccess/addon-datastore-validation#32, create translated views of each add-on Related PRs: - nvaccess/addon-datastore-validation#32 - #1095
seanbudd
added a commit
that referenced
this pull request
Mar 17, 2026
Append all translations to the add-on submission when creating the JSON submission file from a downloaded add-on manifest. Adds a script to regenerate translations for all add-ons. Translations for displayName and description are append to the JSON submission file. These translations will be used for the transformation to views in a subsequent PR to `-transform`: - nvaccess/addon-datastore-transform#23 - #1095
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow to regenerate translations of all add-ons in the repository
Related PRs to finalize localisation support:
Tested end-to-end, to generate the following views: https://github.com/nvaccess/addon-datastore-staging/tree/views/views