Rather than changing this on nvdaControls.MessageDialog, can you amend the messages directly?

Rather than changing this on nvdaControls.MessageDialog, can you amend the messages directly?

Sorry, I am not sure to understand. Could you please be more specific? Could you indicate which message I should amend and where?

Also, in the initial description, I have written:

Putting here an accelerator key does not make sense here since the wx.StaticText used in this dialog is not the label of a focusable element.

If you disagree with this statement, could you explain why?

I was hoping this could happen on the string injection side, rather than in MessageDialog, e.g. updating gui.addonGui,_showConfirmAddonInstallDialog to replace "&" with "&&" in the confirmInstallMessage.

Generally we expect inputs to be correct, rather than fixed by the dialog. One risk of this is strings that already escaped, e.g. "foo && bar", getting escaped again into "foo &&&& bar"

I was hoping this could happen on the string injection side, rather than in MessageDialog, e.g. updating gui.addonGui,_showConfirmAddonInstallDialog to replace "&" with "&&" in the confirmInstallMessage.

That was my idea, before realizing that the issue was broader.

Generally we expect inputs to be correct, rather than fixed by the dialog. One risk of this is strings that already escaped, e.g. "foo && bar", getting escaped again into "foo &&&& bar"

Why do you consider that the "correct" input is a string where ampersand indicate an accelerator? The dialog is abstracted and from the point of view of a developer, the developer using this dialog does not need to know that the implementation uses a wx.StaticText, that the text of the message would be passed directly to wx.StaticText and thus that ampersands should be doubled.

On the contrary, I consider that there is no sense putting an accelerator in this string. It makes sense to use an accelerator only with objects that can perform actions or be focused, or wx.StaticText acting as labels for such objects. But in the present case, the wx.StaticText is not a label for another object but a message. Why would a developer using this dialog use an accelerator on this text object? Could you give an example?

Going further with a comparison

Note also the following test on standard Windows MessageBox (for an illustrating comparison only). In the Python console, type:

import winUser
winUser.MessageBox(0, 'Hello &world', 'Test', 0)

Visually, you can see that the message in the message box is "Hello &world" (with ampersand). Ampersand in the input string is not used to create an accelerator key.

Be careful to check visually and not with ATs since there is another issue, see below.

Additional issue with text reported in winUser.MessageBox

There is an additional issue with the text reported by winUser.MessageBox. This is beyond the work of this PR.

In the previous example:
winUser.MessageBox(0, 'Hello &world', 'Test', 0)
As written before, the text is visually "Hello aworld" (with ampersand). However the text reported by NVDA when object navigating to the message or when reading the whole dialog with NVDA+B is "Hello world" (without ampersand), and a possible shortcut key "alt+W" is reported. Pressing alt+W makes no action and a Windows error "ding" is heard, which IMO confirms that there is actually no shortcut. Note also that the Narrator also reports wrongly this shortcut key, which seems to points to an issue with how Windows presents things to ATs. The information on the object containing the message text indicates the following:

name: 'Hello world'
windowText: 'Hello &world'
displayText: 'Hello &world'
IAccessible accName: 'Hello world'

This is a convincing argument.