Skip to content

Fix on the panel's name in the multi-category settings dialog#14996

Merged
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:ampersandInPanel
Jun 13, 2023
Merged

Fix on the panel's name in the multi-category settings dialog#14996
seanbudd merged 1 commit into
nvaccess:masterfrom
CyrilleB79:ampersandInPanel

Conversation

@CyrilleB79

@CyrilleB79 CyrilleB79 commented Jun 9, 2023

Copy link
Copy Markdown
Contributor

Link to issue number:

Issue similar to #14607.

Summary of the issue:

In the multi-category settings dialog, the panel takes the name of the corresponding category. This name is reported when tabbing from the category list to the panel. If the category name contains an ampersand, this character is not reported in the panel's name and it acts as an accelerator instead.

This is the case for NVDA Dev & Test Toolbox add-on where the add-on's name is used as category in the multi-category settings dialog and thus also as panel name.

Description of user facing changes

The panel's name will match the category name, even in the case this name contains an ampersand (&) character.

Description of development approach

Double the ampersand in the panel's name.

Testing strategy:

  • Tested that the issue is fixed for NVDA Dev & Test toolbox 4.0.n
  • Also tested on another add-on (Clock add-on), renaming the panel's title to "Clock&Bells" and checked the change:
    • With NVDA 2023.1: the category in the list and the dialog's title reads "Clock&Bells" but the panel's name is "ClockBells" and when setting the nav object on this panel (property page), an alt+B shortcut is reported. This accelerator does not work however.
    • With this PR: the category in the list and the dialog's title reads "Clock&Bells" as well as the panel's name and when setting the nav object on this panel (property page), no shortcut is reported.

Known issues with pull request:

None

Change log entries:

Not needed for a such little fix.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit ed91ed7980

@CyrilleB79 CyrilleB79 marked this pull request as ready for review June 10, 2023 20:24
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner June 10, 2023 20:24
@CyrilleB79 CyrilleB79 requested a review from seanbudd June 10, 2023 20:24
@CyrilleB79

Copy link
Copy Markdown
Contributor Author

Unrelated system test failure.

(System tests regularly fail recently. Maybe due to Chrome update?)

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CyrilleB79

@seanbudd seanbudd merged commit f8afefd into nvaccess:master Jun 13, 2023
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 13, 2023
@CyrilleB79 CyrilleB79 deleted the ampersandInPanel branch June 13, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants