Skip to content

Update eSpeak to a51235aa commit#14517

Merged
seanbudd merged 3 commits into
masterfrom
updateEspeak2023.1
Jan 6, 2023
Merged

Update eSpeak to a51235aa commit#14517
seanbudd merged 3 commits into
masterfrom
updateEspeak2023.1

Conversation

@seanbudd

@seanbudd seanbudd commented Jan 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

#14483 was reverted via #14516 due to an issue with rate boost.
eSpeak changed the compilation flag, and that change wasn't in the Makefile.am diff, so it was missed.
This is fixed in 7e558da

Link to issue number:

Closes #14281
Closes #14241
Addresses #13875 (comment)

Summary of the issue:

Janitorial update of eSpeak.
Removes a workaround added to handle a bug with eSpeaks BreakCommand implementation, tracked in espeak-ng/espeak-ng#1232, #13875 (comment)

Description of user facing changes

eSpeak is updated.
Fixes pronunciation of large numbers (#14241).

Description of development approach

Dropped strength for eSpeak BreakCommand attribute per espeak-ng/espeak-ng#1232 being fixed in eSpeak.

Janitorial update

Followed instructions in include/espeak.md.
Checked the following diffs.

cd include/espeak
git diff a51235aa b17ed2d6 src/windows/config.h
git diff a51235aa b17ed2d6 Makefile.am

Addressed the following eSpeak changes:

Testing strategy:

Manual testing:

Known issues with pull request:

None

Change log entries:

Refer to diff

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner January 5, 2023 22:17
@seanbudd seanbudd requested a review from feerrenrut January 5, 2023 22:17
@seanbudd seanbudd requested review from michaelDCurran and removed request for feerrenrut January 6, 2023 00:49
@seanbudd

seanbudd commented Jan 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

@LeonarddeR @zstanecic I believe I've fixed up rate boost on this PR. eSpeak changed the compilation flag, and that change wasn't in the Makefile.am diff, so it was missed. Can you confirm when the build has completed? I will post the link when it is ready.

@seanbudd

seanbudd commented Jan 6, 2023

Copy link
Copy Markdown
Member Author

The build to test with: https://ci.appveyor.com/api/buildjobs/4e428ekbmspqsnrw/artifacts/output%2Fnvda_snapshot_pr14517-27443%2C54af5d6b.exe

@zstanecic

zstanecic commented Jan 6, 2023 via email

Copy link
Copy Markdown
Contributor

@LeonarddeR

LeonarddeR commented Jan 6, 2023

Copy link
Copy Markdown
Collaborator

Yes, works like a charm. Go ahead merging this 👍🏻

@seanbudd seanbudd merged commit 6dd9002 into master Jan 6, 2023
@seanbudd seanbudd deleted the updateEspeak2023.1 branch January 6, 2023 07:59
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelDCurran michaelDCurran michaelDCurran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2023.1

Development

Successfully merging this pull request may close these issues.

Update eSpeak for 2023.1 Espeak reads numbers more than 34 digits as 3647

5 participants

@seanbudd @zstanecic @LeonarddeR @michaelDCurran @nvaccessAuto