Update eSpeak to a51235aa commit#14483
Merged
Merged
Conversation
See test results for failed build of commit 09ce145efd |
michaelDCurran
approved these changes
Jan 4, 2023
Collaborator
|
On latest Alpha, it looks like rate boost is no longer working. |
Contributor
|
Hi!
Can be reproduced using NVDA version alpha-27428,a34da142
From: Leonard de Ruijter ***@***.***>
Sent: Thursday, January 5, 2023 8:13 AM
To: nvaccess/nvda ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [nvaccess/nvda] Update eSpeak to a51235aa commit (PR #14483)
On latest Alpha, it looks like rate boost is no longer working.
—
Reply to this email directly, view it on GitHub <#14483 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDE3NYAXONEA4O2LREZDWQZX57ANCNFSM6AAAAAATLVYIFE> .
You are receiving this because you are subscribed to this thread. <https://github.com/notifications/beacon/ACVCDE355DQWYOADXZZENYTWQZX57A5CNFSM6AAAAAATLVYIFGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSRYTTKO.gif> Message ID: ***@***.*** ***@***.***> >
|
Collaborator
|
@seanbudd Can this possibly be reverted while investigating? |
seanbudd
added a commit
that referenced
this pull request
Jan 5, 2023
This comment was marked as off-topic.
This comment was marked as off-topic.
6 tasks
seanbudd
added a commit
that referenced
this pull request
Jan 6, 2023
#14483 was reverted via #14516 due to an issue with rate boost. eSpeak changed the compilation flag, and that change wasn't in the Makefile.am diff, so it was missed. This is fixed in 7e558da Link to issue number: Closes #14281 Closes #14241 Addresses #13875 (comment) Summary of the issue: Janitorial update of eSpeak. Removes a workaround added to handle a bug with eSpeaks BreakCommand implementation, tracked in espeak-ng/espeak-ng#1232, #13875 (comment) Description of user facing changes eSpeak is updated. Fixes pronunciation of large numbers (#14241). Description of development approach Dropped strength for eSpeak BreakCommand attribute per espeak-ng/espeak-ng#1232 being fixed in eSpeak. Janitorial update Followed instructions in include/espeak.md. Checked the following diffs. cd include/espeak git diff a51235aa b17ed2d6 src/windows/config.h git diff a51235aa b17ed2d6 Makefile.am Addressed the following eSpeak changes: Introduction of langopts.c: espeak-ng/espeak-ng@4a28902 Fix up of code standards: change DINCLUDE to DUSE: espeak-ng/espeak-ng@ca1f590 Note that eSpeak has changed MBROLA compilation, does not affect our build: espeak-ng/espeak-ng@78ac6c4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #14281
Closes #14241
Addresses #13875 (comment)
Summary of the issue:
Janitorial update of eSpeak.
Removes a workaround added to handle a bug with eSpeaks
BreakCommandimplementation, tracked in espeak-ng/espeak-ng#1232, #13875 (comment)Description of user facing changes
eSpeak is updated.
Fixes pronunciation of large numbers (#14241).
Description of development approach
Dropped
strengthfor eSpeakBreakCommandattribute per espeak-ng/espeak-ng#1232 being fixed in eSpeak.Janitorial update
Followed instructions in
include/espeak.md.Checked the following diffs.
Addressed the following eSpeak changes:
langopts.c: espeak-ng/espeak-ng@4a28902DINCLUDEtoDUSE: espeak-ng/espeak-ng@ca1f590Testing strategy:
Manual testing:
BreakCommandwith eSpeak.Known issues with pull request:
None
Change log entries:
Refer to diff
Code Review Checklist: