Only check the lock screen order if NVDA is installed#14487
Merged
Conversation
michaelDCurran
approved these changes
Jan 4, 2023
Collaborator
|
I'm pretty sure not whether NVDA is installed, but whether it has UI access is the variable to check here. I'm running a try build as an installed copy (something that's discouraged of course) but am also getting weird errors on the lock screen. Could you please investigate this? |
Member
|
Yes, I agree this would be a more accurate approach. |
6 tasks
seanbudd
added a commit
that referenced
this pull request
Jan 5, 2023
Fixup of #14487 Summary of the issue: NVDA can only detect the lock screen windows, and windows below the lock screen, if NVDA has UI Access. When running a portable copy, or NVDA from source, locking NVDA causes an error every cache cycle due to the lock screen not being detected. #14487 checked installation status., but checking UIAccess is a more accurate approach. Description of user facing changes logging/error sounds are suppressed when locking Windows and using a portable or source copy of NVDA Description of development approach Lock screen z-order is only checked if the current running version of NVDA has UIAccess (e.g. is installed normally).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
NVDA can only detect the lock screen windows, and windows below the lock screen, if NVDA is installed.
When running a portable copy, or NVDA from source, locking NVDA causes an error every cache cycle due to the lock screen not being detected.
Description of user facing changes
logging/error sounds are suppressed when locking Windows and using a portable or source copy of NVDA
Description of development approach
Lock screen z-order is only checked if the current running version of NVDA is installed.
Testing strategy:
Smoke test the lock screen with a portable, installed and source copy of NVDA.
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: