Skip to content

Only check the lock screen order if NVDA has UIAccess#14511

Merged
seanbudd merged 1 commit into
masterfrom
fixup-14487
Jan 5, 2023
Merged

Only check the lock screen order if NVDA has UIAccess#14511
seanbudd merged 1 commit into
masterfrom
fixup-14487

Conversation

@seanbudd

@seanbudd seanbudd commented Jan 4, 2023

Copy link
Copy Markdown
Member

Link to issue number:

Fixup of #14487

Summary of the issue:

NVDA can only detect the lock screen windows, and windows below the lock screen, if NVDA has UI Access.
When running a portable copy, or NVDA from source, locking NVDA causes an error every cache cycle due to the lock screen not being detected.
#14487 checked installation status., but checking UIAccess is a more accurate approach.

Description of user facing changes

logging/error sounds are suppressed when locking Windows and using a portable or source copy of NVDA

Description of development approach

Lock screen z-order is only checked if the current running version of NVDA has UIAccess (e.g. is installed normally).

Testing strategy:

Smoke test the lock screen with a portable, installed and source copy of NVDA.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner January 4, 2023 22:52
@seanbudd seanbudd requested review from feerrenrut and michaelDCurran and removed request for feerrenrut January 4, 2023 22:52
@seanbudd seanbudd merged commit 0c84d68 into master Jan 5, 2023
@seanbudd seanbudd deleted the fixup-14487 branch January 5, 2023 00:18
@nvaccessAuto nvaccessAuto added this to the 2023.1 milestone Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants