Wait for speech adjustment#14284
Merged
Merged
Conversation
Since Appveyor seems to be less performant than previously, give NVDA more time to handle events and get all speech out. This will increase the time system tests take. System tests could be optimised to reduce usages of wait_for_speech_to_finish. In many cases, wait_for_specific_speech could be preferable.
Note the index of captured speech, to be used by system tests. This is not to be conflated with the speech IndexCommands.
seanbudd
reviewed
Oct 25, 2022
seanbudd
approved these changes
Oct 25, 2022
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
Last build test failure The wait time may need to be extended, the test gave up waiting just before NVDA was finished exiting. Analysis of the failureHighlights from NVDA log (context included below): Note the Robot log, from after the quit dialog announcement is checked: NVDA log, from after the quit dialog is announced. |
6 tasks
6 tasks
seanbudd
added a commit
that referenced
this pull request
Dec 7, 2022
Summary of the issue: Due to intermittent system test failures, #14284 increased the polling interval used in blockUntilConditionMet. When writing unit tests for blockUntilConditionMet in #14301, a bug was picked up. This bug caused blockUntilConditionMet to spin for longer than expected and potentially caused system tests to fail. This bug was fixed with a new implementation of blockUntilConditionMet. Description of user facing changes For devs, system tests should be faster (todo: estimate from build?) Description of development approach Lower default polling interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Splitting up PR #14054
Summary of the issue:
wait_for_speech_to_finishdo not specify the speech index for speech started (which usually should benextSpeechIndex)._NvdaLib.getSpeechAfterKeyrather thanspy.emulateKeyPress,wait_for_speech_to_finishand then get speech after index.getSpeechAfterKeyhandles this all internally.Description of user facing changes
None
Description of development approach
wait_for_speech_to_finishandemulateKeyPressto see ifgetSpeechAfterKeyis more appropriate, or ifnextSpeechIndexneeds to be used.Testing strategy:
System tests on alpha
Known issues with pull request:
This PR appears to increase the time for tests from 15 min to ~22 min.
Change log entries:
None
Code Review Checklist: