Lower poll interval for blockUntilConditionMet#14324
Merged
Merged
Conversation
Merged
feerrenrut
approved these changes
Nov 4, 2022
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
This change looks good, but I'd like to know if system tests on master are stable before we merge this. It looks like it reduces the test time from 26.7 min to 23.3 min (only based on one run of each branch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Due to intermittent system test failures, #14284 increased the polling interval used in
blockUntilConditionMet.When writing unit tests for
blockUntilConditionMetin #14301, a bug was picked up. This bug causedblockUntilConditionMetto spin for longer than expected and potentially caused system tests to fail.This bug was fixed with a new implementation of
blockUntilConditionMet.Description of user facing changes
For devs, system tests should be faster (todo: estimate from build?)
Description of development approach
Lower default polling interval
Testing strategy:
Monitor system tests for a while, check if
blockUntilConditionMetcauses a system test failure.Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: