Skip to content

Merge beta to master#13988

Merged
seanbudd merged 25 commits into
masterfrom
beta
Aug 5, 2022
Merged

Merge beta to master#13988
seanbudd merged 25 commits into
masterfrom
beta

Conversation

@seanbudd

@seanbudd seanbudd commented Aug 5, 2022

Copy link
Copy Markdown
Member

Must be merge commit not squash merge

NVDA translation automation and others added 25 commits July 28, 2022 00:30
From translation svn revision: 69103

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
3	3	source/locale/de/LC_MESSAGES/nvda.po
 1 file changed, 3 insertions(+), 3 deletions(-)
From translation svn revision: 69103

Authors:
Beqa Gozalishvili <beqaprogger@gmail.com>
Goderdzi Gogoladze <goderdzigogoladze@gmail.com>

Stats:
1456	1196	source/locale/ka/LC_MESSAGES/nvda.po
 1 file changed, 1456 insertions(+), 1196 deletions(-)
From translation svn revision: 69103

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
53	53	source/locale/zh_CN/characterDescriptions.dic
 1 file changed, 53 insertions(+), 53 deletions(-)
From translation svn revision: 69103
From translation svn revision: 69106

Authors:
Beqa Gozalishvili <beqaprogger@gmail.com>
Goderdzi Gogoladze <goderdzigogoladze@gmail.com>

Stats:
49	50	source/locale/ka/LC_MESSAGES/nvda.po
 1 file changed, 49 insertions(+), 50 deletions(-)
From translation svn revision: 69106
Fixes #13969
Fixes #13966

Background for the feature in PR #13550

Summary of the issue:
NVDA does not correctly handle language switching commands when speaking character descriptions.

Description of user facing changes
Ensure character descriptions are read in the proper locale where known.

Description of development approach
Use the same code other spelling commands use, _getSpellingSpeechWithoutCharMode, which handles language switching.
From translation svn revision: 69245

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
201	34	source/locale/de/LC_MESSAGES/nvda.po
5	1	source/locale/de/symbols.dic
 2 files changed, 206 insertions(+), 35 deletions(-)
From translation svn revision: 69245

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
205	37	source/locale/es/LC_MESSAGES/nvda.po
4	0	source/locale/es/symbols.dic
69	3	user_docs/es/changes.t2t
51	3	user_docs/es/userGuide.t2t
 4 files changed, 329 insertions(+), 43 deletions(-)
From translation svn revision: 69245

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
200	33	source/locale/fi/LC_MESSAGES/nvda.po
160	156	source/locale/fi/symbols.dic
55	0	user_docs/fi/changes.t2t
53	5	user_docs/fi/userGuide.t2t
 4 files changed, 468 insertions(+), 194 deletions(-)
From translation svn revision: 69245

Authors:
Michel such <michel.such@free.fr>
Patrick ZAJDA <patrick@zajda.fr>
Remy Ruiz <remyruiz@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Cyrille Bougot <cyrille.bougot2@laposte.net>
Corentin Bacqué-Cazenave <corentin@progaccess.net>
Sylvie Duchateau <sylvieduchateau@gmail.com>
Sof <hellosof@gmail.com>

Stats:
199	34	source/locale/fr/LC_MESSAGES/nvda.po
72	0	user_docs/fr/changes.t2t
53	5	user_docs/fr/userGuide.t2t
 3 files changed, 324 insertions(+), 39 deletions(-)
From translation svn revision: 69245

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
203	36	source/locale/gl/LC_MESSAGES/nvda.po
4	0	source/locale/gl/symbols.dic
66	0	user_docs/gl/changes.t2t
51	3	user_docs/gl/userGuide.t2t
 4 files changed, 324 insertions(+), 39 deletions(-)
From translation svn revision: 69245

Authors:
Hrvoje Katic <hrvojekatic@gmail.com>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Milo Ivir <mivir@milotype.de>
Dejana Rakic <dejana.rakic.2@gmail.com>

Stats:
205	36	source/locale/hr/LC_MESSAGES/nvda.po
5	1	source/locale/hr/symbols.dic
55	0	user_docs/hr/changes.t2t
 3 files changed, 265 insertions(+), 37 deletions(-)
From translation svn revision: 69245

Authors:
Takuya Nishimoto <nishimotz@gmail.com>
Minako Nonogaki <minakonono3519@gmail.com>

Stats:
204	35	source/locale/ja/LC_MESSAGES/nvda.po
 1 file changed, 204 insertions(+), 35 deletions(-)
From translation svn revision: 69245

Authors:
Beqa Gozalishvili <beqaprogger@gmail.com>
Goderdzi Gogoladze <goderdzigogoladze@gmail.com>

Stats:
1249	1254	source/locale/ka/LC_MESSAGES/nvda.po
 1 file changed, 1249 insertions(+), 1254 deletions(-)
From translation svn revision: 69245

Authors:
Joseph Lee <joseph.lee22590@gmail.com>
Chang-Hwan Jang <462356@gmail.com>
Dong Hee Park <hi@aheu.org>
Stanley Chung <stanley@mail.com>

Stats:
201	35	source/locale/ko/LC_MESSAGES/nvda.po
 1 file changed, 201 insertions(+), 35 deletions(-)
From translation svn revision: 69245

Authors:
Diogo Costa <diogojoca@gmail.com>
Rui Batista <ruiandrebatista@gmail.com>
Rui Fontes <rui.fontes@tiflotecnia.com>
Ângelo Abrantes <ampa4374@gmail.com>

Stats:
56	7	user_docs/pt_PT/userGuide.t2t
 1 file changed, 56 insertions(+), 7 deletions(-)
From translation svn revision: 69245

Authors:
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Aleksandr Lin'kov <kvark128@yandex.ru>

Stats:
4	82	source/locale/ru/symbols.dic
 1 file changed, 4 insertions(+), 82 deletions(-)
From translation svn revision: 69245

Authors:
Dinakar T.D. <td.dinkar@gmail.com>

Stats:
200	35	source/locale/ta/LC_MESSAGES/nvda.po
5	1	source/locale/ta/symbols.dic
 2 files changed, 205 insertions(+), 36 deletions(-)
From translation svn revision: 69245

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
11	0	source/locale/tr/symbols.dic
53	22	user_docs/tr/userGuide.t2t
 2 files changed, 64 insertions(+), 22 deletions(-)
From translation svn revision: 69245

Authors:
Volodymyr Pyrig <vp88.mobile@gmail.com>

Stats:
208	41	source/locale/uk/LC_MESSAGES/nvda.po
 1 file changed, 208 insertions(+), 41 deletions(-)
From translation svn revision: 69245

Authors:
Dang Hoai Phuc <danghoaiphuc@gmail.com>
Nguyen Van Dung <dungnv1984@gmail.com>

Stats:
56	0	user_docs/vi/changes.t2t
53	5	user_docs/vi/userGuide.t2t
 2 files changed, 109 insertions(+), 5 deletions(-)
From translation svn revision: 69245
* Dump speech / devInfo / braille from main thread
These require access to IAccessible or RPC, which must happen from
main thread.

* Easier test selection for devs
- When "--include NVDA" is present, it isn't possible to
select some other tag only, tests matching either tag will be run.
- This results in many tests running when a developer may only wish to run chrome, or symbols tests.
- The initial intention was to prevent developers accidentally running installer tests.
- Now achieved by supplying a tag that matches no tests.

* Ensure hwnd vals are comparable
- HWND passed into EnumWindowsProc
was a lpclong, other HWND vals were integer objects,
comparisons for the same HWND were always false.

* Fix chrome process tracking
- Keep the 'start' process around until chrome exits (/wait)
  Track this independently of the chrome process
- Look up the chrome window handle and title and save to instance var on
  the library instance. Work with "Window" class instances rather than HWND
  directly.
- Use the start process to confirm exit, logging shows that the start
  process still exists prior to sending control w, but not after.

* Don't use kiosk mode for chrome
So that screenshots can contain more information.

* Don't use win32 to focus chrome.
The test unable to set the foreground window with user32.SetForegroundWindow
Testing locally shows that this won't work, documentation backs this up.
The RF test runner process is not the foreground process.
See docs: https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-setforegroundwindow#remarks

* Wait for start marker
Adjustments to how the tests check for the start marker.
Now:
- move focus to the address bar explicitly (for a known starting point)
- move the focus to the document with an explicit chrome shortcut 
- report the current line

* Toggle chrome focus
Introduces an optional de/re-focus of chrome (currently disabled).
This may help to work-around issues with NVDA missing foreground events / not injecting.
- view desktop
- alt+tab back to chrome
- wait for chrome to be foreground app

* Don't exit chrome after each test
- Initially this was done to ensure a "clean slate" for each subsequent test.
- However, each test sample loads in a new tab already, the risk of interference between tabs is low.
- Exiting the tab / chrome is disabled on the off-chance that the action of closing and opening
chrome causes delays, or causes chrome to run background updates, or other actions which may
interfere with the tests on appveyor,
- Additionally, for developers, it is easier to inspect test samples after the test runs if they are left 
open which may be important if the test fails.
- However, this leaves many tabs open for the developer to tidy up.

* Add note about postmortem debugger
The debug_break command can be caught by a postmortem debugger.

* Give robot remote server more time to start up
- Appveyor systems seem to have become slower.
- Some the amount of time it takes for NVDA to start up is approaching 10 seconds.
- Add logging to be able to inspect the timing of various steps to start NVDA during system tests.
Summary of the issue:
A log message used during development was left in PR #13851

Description of user facing changes
Reduces noise in the NVDA.log

Description of development approach
Removed the logging of this message.
@seanbudd seanbudd marked this pull request as ready for review August 5, 2022 03:42
@seanbudd seanbudd requested a review from a team as a code owner August 5, 2022 03:42
@seanbudd seanbudd requested a review from feerrenrut August 5, 2022 03:42
@seanbudd seanbudd merged commit 8b4c462 into master Aug 5, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants