Skip to content

remove log message used during development#13984

Merged
seanbudd merged 1 commit into
betafrom
removeDebugLog
Aug 5, 2022
Merged

remove log message used during development#13984
seanbudd merged 1 commit into
betafrom
removeDebugLog

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

#13851 (review)

Summary of the issue:

A log message used during development was left in PR #13851

Description of user facing changes

Reduces noise in the NVDA.log

Description of development approach

Removed the logging of this message.

Testing strategy:

Beta / alpha testsing
This is a very low risk change.

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut requested a review from a team as a code owner August 4, 2022 05:42
@feerrenrut feerrenrut requested review from seanbudd and removed request for a team August 4, 2022 05:42
@AppVeyorBot

This comment was marked as outdated.

@feerrenrut

Copy link
Copy Markdown
Contributor Author

Unrelated system test failures in build 26091:

  • Robot.chromeTests.ARIA details with free review and nav
  • Robot.chromeTests.ARIA detailsRobot
  • Robot.chromeTests.i7562

Restarting build.

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 41e5037d71

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 41e5037d71

@seanbudd seanbudd merged commit 2e1ffba into beta Aug 5, 2022
@seanbudd seanbudd deleted the removeDebugLog branch August 5, 2022 03:41
@nvaccessAuto nvaccessAuto added this to the 2022.4 milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants