Use locale for delayed character descriptions#13972
Conversation
|
The test done in this PR checks #13969 has been fixed, but there is no test to check that #13966. @LittleStar-VIP, would you mind test the build of this PR and check that all the descriptions are reported for a character if you enable delayed character description? Thanks. |
|
@CyrilleB79 |
|
@seanbudd After comparing the character description of the respective folder, the above line of character description is found in the file "X:\NVDA PR\locale\zh\characterDescriptions.dic" I remember somewhere else mentioned that the character description here is a no longer maintained file of character description. |
|
@LittleStar-VIP - if the description is consistent across gestures, I think #13966 is fixed. |
|
@seanbudd |
|
the character description for the word 香should be "香 香水 香港 香味 芳香 百里香 焚香頂禮" in tw locale |
|
This PR is blocked by a test sample and STR for #13966, so that the behaviour for the sample can be compared with 2022.2 and this PR. |
|
I have created a new issue regarding the character description problem which I mentioned above |
Link to issue number:
Fixes #13969
Fixes #13966
Background for the feature in PR #13550
Summary of the issue:
NVDA does not correctly handle language switching commands when speaking character descriptions.
Description of user facing changes
Ensure character descriptions are read in the proper locale where known.
Description of development approach
Use the same code other spelling commands use,
_getSpellingSpeechWithoutCharMode, which handles language switching.Testing strategy:
data:text/html,<div lang="de" contenteditable="true">Hello! World</div>Known issues with pull request:
None
Change log entries:
None: unreleased feature
Code Review Checklist: