Introduce table sayAll commands#13956
Closed
seanbudd wants to merge 3 commits into
Closed
Conversation
See test results for failed build of commit 4820c4a69e |
See test results for failed build of commit 89001333ab |
6 tasks
Member
Author
|
Superseded by #14070 |
seanbudd
pushed a commit
that referenced
this pull request
Aug 30, 2022
Fixes #13469. Fixes #13927. Summary of the issue: Previous PR #13956 broke sayAll functionality in BookWorm (#13927) and therefore was reverted. This PR undoes reverting, in other words it reintroduces table sayAll commands. It also contains a minor change that fixes sayAll in BookWorm. Description of user facing changes Reintroduces table sayAll commands. Description of development approach In my original PR #13956 I did a minor refactoring of SayAll classes, in order to avoid code reduplication and have a nice class inheritance. In order to achieve this I slightly rearranged calls to textInfo. This didn't affect functionality anywhere except for page turn detector in BookWorm. Reverting to the original order of TextInfo calls at the cost of slightly less elegant code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Credit @mltony
This feature was on track for release with 2022.3, however it was found to cause / uncover issues that could not be resolved quickly. Rather than delay the release of 2022.3, this feature was reverted in PR #13954.
Link to issue number:
Reverts #13954
Fixes #13469
Summary of the issue:
Feature request: add table sayAll commands to read rows and columns.
Description of how this pull request fixes the issue:
Adds 4 commands:
Additionally:
Testing strategy:
Known issues with pull request:
Change log entries:
Refer to PR diff
Code Review Checklist: