Revert "Introducing table sayall commands (#13670)" #13954
Merged
Merged
Conversation
This reverts commit 82a4f86.
See test results for failed build of commit fd18032e21 |
feerrenrut
approved these changes
Jul 27, 2022
seanbudd
added a commit
that referenced
this pull request
Jul 27, 2022
5 tasks
mltony
added a commit
to mltony/nvda
that referenced
this pull request
Aug 25, 2022
…vaccess#13954)" This reverts commit 9d25bac.
mltony
added a commit
to mltony/nvda
that referenced
this pull request
Aug 26, 2022
…vaccess#13954)" This reverts commit 9d25bac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Reverts: #13670, #13901
Fixes #13927
Re-introduces: #13469
Summary of the issue:
The fix for #13927 is complex, and will need weeks of testing on alpha.
This means that #13469 is blocked until #13670 can be implemented with #13927 fixed.
Description of user facing changes
Removes table say all commands from 2022.3
Description of development approach
Revert PRs in the right order, fix up the release blurb
Testing strategy:
#13670 has been confirmed as the commit which broke #13927 using a git bisect.
The build from this code has been tested with bookworm.
Known issues with pull request:
None
Change log entries:
See PR diff
Code Review Checklist: