Skip to content

Update CLDR to version 41#13582

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
OzancanKaratas:updateCLDR
Apr 20, 2022
Merged

Update CLDR to version 41#13582
seanbudd merged 4 commits into
nvaccess:masterfrom
OzancanKaratas:updateCLDR

Conversation

@OzancanKaratas

@OzancanKaratas OzancanKaratas commented Apr 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Link to issue number:

None

Summary of the issue:

None

Description of how this pull request fixes the issue:

Unicode has released a new version of the CLDR package.

Testing strategy:

Manually testing: Download the AppVeyor build and tell me what went wrong.

Known issues with pull request:

Previously opened issues with Chinese, Persian and Arabic locales: This issues will not be fixed. See #12097, #12086.

Change log entries:

Changes

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@OzancanKaratas OzancanKaratas requested a review from a team as a code owner April 5, 2022 13:00
@OzancanKaratas OzancanKaratas requested a review from seanbudd April 5, 2022 13:00
@AppVeyorBot

AppVeyorBot commented Apr 5, 2022

Copy link
Copy Markdown

See test results for failed build of commit e36b613e6f

@CyrilleB79

CyrilleB79 commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @OzancanKaratas for taking care to update CLDR in NVDA as soon as there is a new version.

Here is my feedback, just reading the description (no other check):

  • IMO it is worth to specify a change log item as it was done for previous versions (e.g. CLDR 40)
  • In the known issues, you mention a previously opened issues with Chinese locale. Could you add the reference to clearly identify this issue?

@OzancanKaratas

OzancanKaratas commented Apr 5, 2022

Copy link
Copy Markdown
Collaborator Author

Thanks @CyrilleB79, I updated the first comment.

@OzancanKaratas

OzancanKaratas commented Apr 9, 2022

Copy link
Copy Markdown
Collaborator Author

@CyrilleB79, I didn't see a locale change in CLDR 41 that needed to be added to NVDA. Can you take a look please?

@CyrilleB79

CyrilleB79 commented Apr 9, 2022

Copy link
Copy Markdown
Contributor

Sorry, I do not understand what you want me to have a look at.

If you are referring to my last comment, you have modified the two points in the initial description (thanks!). I was not asking anything more.

@OzancanKaratas

OzancanKaratas commented Apr 9, 2022

Copy link
Copy Markdown
Collaborator Author

Okay, thank you. ☺️

@OzancanKaratas OzancanKaratas requested a review from seanbudd April 15, 2022 17:01
@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Apr 19, 2022
@seanbudd seanbudd merged commit 3359664 into nvaccess:master Apr 20, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Apr 20, 2022
@OzancanKaratas OzancanKaratas deleted the updateCLDR branch April 24, 2022 21:11
@OzancanKaratas OzancanKaratas restored the updateCLDR branch April 24, 2022 21:14
@OzancanKaratas OzancanKaratas deleted the updateCLDR branch April 24, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Milestone

2022.2

Development

Successfully merging this pull request may close these issues.

5 participants

@OzancanKaratas @AppVeyorBot @CyrilleB79 @seanbudd @nvaccessAuto