Add secure mode decorators to future-proof code#13548
Merged
Merged
Conversation
michaelDCurran
approved these changes
Mar 28, 2022
CyrilleB79
added a commit
to CyrilleB79/nvda
that referenced
this pull request
Mar 28, 2022
1. `@blockAction.when` now checks and reports first secure mode, then modal. 2. Add secure mode decorators to future-proof `onCheckForUpdateCommand`. 3. Use secure mode decorator for `onSaveConfigurationCommand`.
5 tasks
CyrilleB79
added a commit
to CyrilleB79/nvda
that referenced
this pull request
Mar 28, 2022
1. `@blockAction.when` now checks and reports first secure mode, then modal. 2. Add secure mode decorators to future-proof `onCheckForUpdateCommand`. 3. Use secure mode decorator for `onSaveConfigurationCommand`.
seanbudd
pushed a commit
that referenced
this pull request
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Certain mainFrame commands e.g.
gui.mainFrame.ExampleCommandsare only exposed via the NVDA menu not in secure mode.In the future, input gestures might be created for these commands, exposing them in secure mode.
Additionally, the log viewer is disable in secure mode, so
script_navigatorObject_devInfoshould be blocked, as it is misleading. The logs should not be accessible when running in secure mode.Debug logging in secure screens can be configured with the
serviceDebugparameter.Description of how this pull request fixes the issue:
Adds secure mode decorators to commands that are currently inaccessible in secure mode.
Testing strategy:
The decorator has been tested in #13539 and other PRs.
Other than
script_navigatorObject_devInfo, these messages should be currently inaccessible to the user.Known issues with pull request:
None
Change log entries:
N/A, no user facing changes
Code Review Checklist: