Use blockAction.when decorator to have a message reported in secure mode when trying to open the symbol dialog#13539
Merged
Conversation
…ode when trying to open the symbol dialog.
michaelDCurran
approved these changes
Mar 27, 2022
5 tasks
seanbudd
added a commit
that referenced
this pull request
Mar 28, 2022
Summary of the issue: Certain mainFrame commands `gui.mainFrame.ExampleCommand` are only exposed via the NVDA menu not in secure mode. In the future, input gestures might be created for these commands, exposing them in secure mode. Additionally, the log viewer is disable in secure mode, so script_navigatorObject_devInfo should be blocked, as it is misleading. The logs should not be accessible when running in secure mode. Debug logging in secure screens can be configured with the serviceDebug parameter. Description of how this pull request fixes the issue: Adds secure mode decorators to commands that are currently inaccessible in secure mode. Testing strategy: The decorator has been tested in #13539 and other PRs. Other than script_navigatorObject_devInfo, these messages should be currently inaccessible to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of #13535
Follow-up of #13500
Summary of the issue:
In #13500 a decorator has been introduced to speak a message when an action is unavailable in secure mode.
In parallel an NVDA 2021.3.5 patch release has been produced; this release contains a fix preventing to open the symbol dialog in secure mode. The 2021.3.5 (rc) branch has then been merged into master to get this fix in master.
This led to the fact that no message was reported when trying to use a script to open the symbol dialog in secure mode.
Description of how this pull request fixes the issue:
Added the
blockAction.whendecorator where it was missing.Testing strategy:
Check that the dialog does not open and that a message reports that the action is unavailable in secure screen.
Check that the symbol dialog opens.
Known issues with pull request:
None
Change log entries:
Not needed: fixing an issue not yet released.
Code Review Checklist: