Skip to content

Merge beta to master#13499

Merged
michaelDCurran merged 46 commits into
masterfrom
beta
Mar 17, 2022
Merged

Merge beta to master#13499
michaelDCurran merged 46 commits into
masterfrom
beta

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Merge beta to master: merge commit not squash merge

seanbudd and others added 30 commits February 18, 2022 14:51
Merge master to beta
From translation svn revision: 66145

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
4	4	source/locale/fi/LC_MESSAGES/nvda.po
 1 file changed, 4 insertions(+), 4 deletions(-)
From translation svn revision: 66145

Authors:
Cearbhall OMeadhra <cearbhall.omeadhra@blbc.ie>
Ronan McGuirk <ronan.p.mcguirk@gmail.com>
Kevin Scannell <kscanne@gmail.com>

Stats:
3	2	user_docs/ga/userGuide.t2t
 1 file changed, 3 insertions(+), 2 deletions(-)
From translation svn revision: 66145

Authors:
Dinakar T.D. <td.dinkar@gmail.com>

Stats:
886	584	source/locale/ta/LC_MESSAGES/nvda.po
 1 file changed, 886 insertions(+), 584 deletions(-)
From translation svn revision: 66145

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
6	6	source/locale/zh_CN/LC_MESSAGES/nvda.po
 1 file changed, 6 insertions(+), 6 deletions(-)
From translation svn revision: 66145
From translation svn revision: 66303

Authors:
Bernd Dorer <bdorer@mailbox.org>
David Parduhn <xkill85@gmx.net>
Rene Linke <rene.linke@hamburg.de>
Adriani Botez <adriani.botez@gmail.com>
Karl Eick <hozosch@web.de>
Robert Hänggi <aarjay.robert@gmail.com>
Astrid Waldschmetterling <a.r.waldschmetterling@gmx.de>

Stats:
454	226	source/locale/de/LC_MESSAGES/nvda.po
35	43	source/locale/de/symbols.dic
129	0	user_docs/de/changes.t2t
120	25	user_docs/de/userGuide.t2t
 4 files changed, 738 insertions(+), 294 deletions(-)
From translation svn revision: 66303

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
455	222	source/locale/es/LC_MESSAGES/nvda.po
130	0	user_docs/es/changes.t2t
118	24	user_docs/es/userGuide.t2t
 3 files changed, 703 insertions(+), 246 deletions(-)
From translation svn revision: 66303

Authors:
Michel such <michel.such@free.fr>
Patrick ZAJDA <patrick@zajda.fr>
Remy Ruiz <remyruiz@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Cyrille Bougot <cyrille.bougot2@laposte.net>
Corentin Bacqué-Cazenave <corentin@progaccess.net>
Sylvie Duchateau <sylvieduchateau@gmail.com>
Sof <hellosof@gmail.com>

Stats:
451	222	source/locale/fr/LC_MESSAGES/nvda.po
143	13	user_docs/fr/changes.t2t
119	24	user_docs/fr/userGuide.t2t
 3 files changed, 713 insertions(+), 259 deletions(-)
From translation svn revision: 66303

Authors:
Cearbhall OMeadhra <cearbhall.omeadhra@blbc.ie>
Ronan McGuirk <ronan.p.mcguirk@gmail.com>
Kevin Scannell <kscanne@gmail.com>

Stats:
36	3	user_docs/ga/userGuide.t2t
 1 file changed, 36 insertions(+), 3 deletions(-)
From translation svn revision: 66303

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
449	221	source/locale/gl/LC_MESSAGES/nvda.po
131	1	user_docs/gl/changes.t2t
119	25	user_docs/gl/userGuide.t2t
 3 files changed, 699 insertions(+), 247 deletions(-)
From translation svn revision: 66303

Authors:
Hrvoje Katic <hrvojekatic@gmail.com>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Milo Ivir <mivir@milotype.de>
Dejana Rakic <dejana.rakic.2@gmail.com>

Stats:
442	220	source/locale/hr/LC_MESSAGES/nvda.po
1	1	source/locale/hr/symbols.dic
 2 files changed, 443 insertions(+), 221 deletions(-)
From translation svn revision: 66303

Authors:
zvonimir stanecic <9a5dsz@gozaltech.org>
Ertay Shashko <ertay@outlook.com>
Aleksandar <glupav@gmail.com>
Kiko Lazarev <kristijan.lazarev@gmail.com>

Stats:
1	1	source/locale/mk/symbols.dic
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 66303

Authors:
Grzegorz Zlotowicz <grzezlo@wp.pl>
Patryk Faliszewski <patric3031@wp.pl>
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Dorota Krac <dorkakrac@yandex.com>
Piotr Rakowski <kontakt@piotrrakowski.net>
Hubert Meyer <hubmeyer1989@gmail.com>
Arkadiusz Swietnicki <nuno69a@gmail.com>

Stats:
470	218	source/locale/pl/LC_MESSAGES/nvda.po
1	1	source/locale/pl/symbols.dic
 2 files changed, 471 insertions(+), 219 deletions(-)
From translation svn revision: 66303

Authors:
Zvonimir Stanecic <9a5dsz@gozaltech.org>
Aleksandr Lin'kov <kvark128@yandex.ru>

Stats:
1	1	source/locale/ru/symbols.dic
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 66303

Authors:
Nikola Jovic <wwenikola123@gmail.com>
Janko Valencik <janko.valencik@alfanum.co.rs>
Zvonimir <9a5dsz@gozaltech.org>
Danijela Popovic <vlajna95@gmail.com>

Stats:
443	219	source/locale/sr/LC_MESSAGES/nvda.po
 1 file changed, 443 insertions(+), 219 deletions(-)
From translation svn revision: 66303

Authors:
Dinakar T.D. <td.dinkar@gmail.com>

Stats:
433	411	source/locale/ta/LC_MESSAGES/nvda.po
 1 file changed, 433 insertions(+), 411 deletions(-)
From translation svn revision: 66303

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
458	232	source/locale/tr/LC_MESSAGES/nvda.po
128	0	user_docs/tr/changes.t2t
 2 files changed, 586 insertions(+), 232 deletions(-)
From translation svn revision: 66303

Authors:
Volodymyr Pyrig <vp88.mobile@gmail.com>

Stats:
1	1	source/locale/uk/symbols.dic
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 66303

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
2	2	source/locale/zh_CN/symbols.dic
 1 file changed, 2 insertions(+), 2 deletions(-)
From translation svn revision: 66303
From translation svn revision: 66326

Authors:
unable to find language: bn

Stats:
5	5	source/locale/bn/symbols.dic
 1 file changed, 5 insertions(+), 5 deletions(-)
From translation svn revision: 66326

Authors:
Jani Kinnunen <janikinnunen340@gmail.com>
Isak Sand <isak.sand@gmail.com>

Stats:
452	225	source/locale/fi/LC_MESSAGES/nvda.po
76	7	user_docs/fi/changes.t2t
130	35	user_docs/fi/userGuide.t2t
 3 files changed, 658 insertions(+), 267 deletions(-)
From translation svn revision: 66326

Authors:
Michel such <michel.such@free.fr>
Patrick ZAJDA <patrick@zajda.fr>
Remy Ruiz <remyruiz@gmail.com>
Abdelkrim Bensaid <abdelkrim.bensaid@free.fr>
Cyrille Bougot <cyrille.bougot2@laposte.net>
Corentin Bacqué-Cazenave <corentin@progaccess.net>
Sylvie Duchateau <sylvieduchateau@gmail.com>
Sof <hellosof@gmail.com>

Stats:
1	1	user_docs/fr/userGuide.t2t
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 66326

Authors:
Simone Dal Maso <simone.dalmaso@gmail.com>
Alberto Buffolino <a.buffolino@gmail.com>

Stats:
465	216	source/locale/it/LC_MESSAGES/nvda.po
 1 file changed, 465 insertions(+), 216 deletions(-)
From translation svn revision: 66326

Authors:
Takuya Nishimoto <nishimotz@gmail.com>
Minako Nonogaki <minakonono3519@gmail.com>

Stats:
405	220	source/locale/ja/LC_MESSAGES/nvda.po
 1 file changed, 405 insertions(+), 220 deletions(-)
From translation svn revision: 66326

Authors:
Bram Duvigneau <bram@bramd.nl>
Bart Simons <bart@bartsimons.be>
A Campen <a.campen@wxs.nl>
Leonard de Ruijter <alderuijter@gmail.com>

Stats:
122	30	user_docs/nl/userGuide.t2t
 1 file changed, 122 insertions(+), 30 deletions(-)
From translation svn revision: 66326

Authors:
Volodymyr Pyrig <vp88.mobile@gmail.com>

Stats:
447	221	source/locale/uk/LC_MESSAGES/nvda.po
 1 file changed, 447 insertions(+), 221 deletions(-)
From translation svn revision: 66326

Authors:
vgjh2005@gmail.com
jiangtiandao901647@gmail.com
manchen_0528@outlook.com
dingpengyu06@gmail.com
singer.mike.zhao@gmail.com
1872265132@qq.com

Stats:
459	243	source/locale/zh_CN/LC_MESSAGES/nvda.po
 1 file changed, 459 insertions(+), 243 deletions(-)
From translation svn revision: 66326
feerrenrut and others added 16 commits March 11, 2022 16:33
2022.1 will be a compatibility breaking release (for add-ons).
Summary:
With UIA for Excel disabled, navigating to a cell with a formula and "has formula" was not reported.
This is a regression caused by #13414

In `NVDAHelper/remote/excel.cpp` the properties of a cell were determined and bits were set on the `state` member of a `EXCEL_CELLINFO` struct.
The constants used for this are in `NVDAHelper/remote/excel/Constants.h`, see the `NVSTATE_*` constants, previously these matched the `controlTypes.State` constants directly. 

Description of change:
Rather than couple the excel implementation to the controlTypes implementation, these constants have been converted to enums (both in C++ and in Python), renumbered, and an explicit mapping to the corresponding `controlTypes.State` enum has been created.

Fixes #13457
Following PR: #13465
Two locations were not correctly updated to type std::uint64_t
Summary:
- Gecko applications (Firefox / thunderbird / instantbird) were occasionally raising a COM error "No such interface supported" when aria-details relation is fetched.
- This exception should be handled as per getIA2RelationFirstTarget.

Additionally:
- getIA2RelationFirstTarget failed to convert IUnknown to NVDAObject.IAccessible. This was missed due to failure with typing system, ctypes.POINTER(IUnknown) is not recognized and becomes Any.
- Unnecessary Firefox error logging on a missing detailsSummary.

This change:
- Prevent ComError escaping when checking for aria-details by using getIA2RelationFirstTarget directly.
- Ensure that IUnkown is converted to an IAccessible in getIA2RelationFirstTarget
- Remove unnecessary Firefox error log on missing detailsSummary.

Fixes #13433
Fixes #13430
… at the end of the document (#13477)

Fixes #13458
fixes #13459
Partial fix for #13462

Summary of the issue:
In MS word via UIA:
When at the end of a document and arrowing left or up into existing content, or when on a blank table cell and arrowing, tabbing or NVDA table cell navigating back into a cell with content, NVDA reports all formatting set for automatic reporting, even if the formatting between the blank position and the existing content does not differ.
For example, when on a blank table cell and pressing control+alt+leftArrow and moving to a cell with existing content, NVDA will report "section 1, page 1" before reporting the content of the cell. If the user has enabled automatic reporting of font color, then the font color will also be included.
This is due to the fact that NVDA fails to fetch formatting for blank table cells, and the insertion point at the end of the document. But still clears the formatting cache. Thus when fetching valid formatting after this, all the formatting is treated as changed.
Related somewhat to this, is the fact that new list items are not announced when being inserted at the end of the document.

Description of how this pull request fixes the issue:
• UIAHandler.utils.iterUIARangeByUnit: when at the end of the document, it is impossible to move by unit at all. Thus if we cannot walk at all, then just yield the original range. This ensures that we do actually fetch text and fields for the insertion point at the end of the document.
• UIATextInfo's _getTextWithFields_text: don't refuse to yield a formatField before an empty text string. This is true on empty table cells and at the end of the document.
GitHub Advisory GHSA-354r-wr4v-cx28:

Summary:
With the --debug-logging NVDA command line option, it was possible to
enable debug logging in secure mode.
From a secure screen, it was possible to activate debug logging by
restarting NVDA and selecting "Restart with debug logging" in the Exit
Dialog.
This created an instance of NVDA performing debug logging from the
system profile, from a secure context.

Description of change
Prevent debug logging in secure mode.
Remove "Restart with debug logging" from the exit dialog options.
Remove "Install pending update" from the exit dialog options.
GitHub Advisory GHSA-mvc8-5rv9-w3hx

Summary:
The wx GUI inspection tool includes a python console.
If the user binds a gesture to the startWxInspectionTool script and
their config is copied to be used on logon screen, this tool could then be
opened from the logon screen.
This would allow a user to open the python console from the logon screen with
system privileges.

Description of change:
Disables opening the wx GUI inspection tool when NVDA is
running in secure mode.
GitHub Advisory GHSA-wg65-7r23-h6p9:

Summary:
The following menu items are hidden from the menu in secure mode:

- Input gesture
- Default dictionary
- Voice dictionary
However it was still possible to assign gestures to the scripts which
open these dialogs.

Modifying speech dictionay or gestures from secure screens could result
in a denial of service.
If unexpected gestures or speech is being replaced, a user may be unable
to sign-in to Windows.

Description of change:
For these commands, return early without opening the dialog if NVDA runs
in secure mode.
cherry-pick change log entries from:
2ec9bcb
Fixes #13463

Summary of the issue:
mathPres.ensureInit is called whenever math content is expected to be read, including from getTextWithFields.
This is called with every read when using UIA with Word.
If mathPlayer is not installed, this pollutes the log.
Ideally, math should be initialized at NVDA startup time.

Description of how this pull request fixes the issue:
Makes mathPlayer initialize on start up.
Removes mathPlayer.ensureInit usages from within NVDA.
External documentation referencing mathPlayer may need to be updated to reflect the need to restart NVDA after installing mathPlayer.
Merge security fixes from 2021.3.4
Merge rather than squash to preserve the commits matching the release-2021.3.4
@seanbudd seanbudd requested review from a team as code owners March 17, 2022 05:36

@Qchristensen Qchristensen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, great work!

@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 55cdef2e11

@michaelDCurran michaelDCurran merged commit c8d9659 into master Mar 17, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.2 milestone Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants