MS Word with UIA: correctly fetch formatting in blank table cells and at the end of the document#13477
Merged
Conversation
…d unit at all (I.e. move returns 0 suggesting no more units left), at very least return the original text range.
seanbudd
previously approved these changes
Mar 15, 2022
Contributor
Reporting of section number is new to 2022.1 via custom patterns, so doesn't represent a regression in UIA support. Maybe just "page number and other formatting"? |
Contributor
|
This PR appears to introuce #13503. I'm going to go ahead and report upstream, because an accessibility call should never cause a provider to crash, but NVDA needs to work around this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #13458
fixes #13459
Partial fix for #13462
Summary of the issue:
In MS word via UIA:
When at the end of a document and arrowing left or up into existing content, or when on a blank table cell and arrowing, tabbing or NVDA table cell navigating back into a cell with content, NVDA reports all formatting set for automatic reporting, even if the formatting between the blank position and the existing content does not differ.
For example, when on a blank table cell and pressing control+alt+leftArrow and moving to a cell with existing content, NVDA will report "section 1, page 1" before reporting the content of the cell. If the user has enabled automatic reporting of font color, then the font color will also be included.
This is due to the fact that NVDA fails to fetch formatting for blank table cells, and the insertion point at the end of the document. But still clears the formatting cache. Thus when fetching valid formatting after this, all the formatting is treated as changed.
Related somewhat to this, is the fact that new list items are not announced when being inserted at the end of the document.
Description of how this pull request fixes the issue:
Testing strategy:
In MS Word via UIA:
Known issues with pull request:
Automatic announcement of new list items numbers/bullets when pressing enter still does not work, probably due to some strangeness with comparing the start of UIA textRanges. further investigation is required on #13462 however at least reading the line manually does announce the new number / bullet.
Change log entries:
New features
Changes
Bug fixes
For Developers
Code Review Checklist: