Merge security fixes from 2021.3.4#13492
Merged
Merged
Conversation
GitHub Advisory GHSA-354r-wr4v-cx28: Summary: With the --debug-logging NVDA command line option, it was possible to enable debug logging in secure mode. From a secure screen, it was possible to activate debug logging by restarting NVDA and selecting "Restart with debug logging" in the Exit Dialog. This created an instance of NVDA performing debug logging from the system profile, from a secure context. Description of change Prevent debug logging in secure mode. Remove "Restart with debug logging" from the exit dialog options. Remove "Install pending update" from the exit dialog options.
GitHub Advisory GHSA-mvc8-5rv9-w3hx Summary: The wx GUI inspection tool includes a python console. If the user binds a gesture to the startWxInspectionTool script and their config is copied to be used on logon screen, this tool could then be opened from the logon screen. This would allow a user to open the python console from the logon screen with system privileges. Description of change: Disables opening the wx GUI inspection tool when NVDA is running in secure mode.
GitHub Advisory GHSA-wg65-7r23-h6p9: Summary: The following menu items are hidden from the menu in secure mode: - Input gesture - Default dictionary - Voice dictionary However it was still possible to assign gestures to the scripts which open these dialogs. Modifying speech dictionay or gestures from secure screens could result in a denial of service. If unexpected gestures or speech is being replaced, a user may be unable to sign-in to Windows. Description of change: For these commands, return early without opening the dialog if NVDA runs in secure mode.
…ityFixesFrom2021.3.4
…ecurityFixesFrom2021.3.4
…Secure' into securityFixesFrom2021.3.4
cherry-pick change log entries from: 2ec9bcb
seanbudd
previously approved these changes
Mar 16, 2022
8d2e47b to
4baaba6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
seanbudd
previously approved these changes
Mar 17, 2022
This comment was marked as outdated.
This comment was marked as outdated.
f89ad2b to
3ffc6f5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
If rebased the commits will no longer match. |
3ffc6f5 to
8d2e47b
Compare
Contributor
Author
|
Each of the commits: Are on this branch and on Merge commits:
|
seanbudd
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue:
Several security fixes have been introduced to address (soon to published) security advisories.
Description of how this pull request fixes the issue:
Note about the state of the rc branch:
Similarly, the security fixes already merged into the rc branch must be merged separately to beta then to master.
To ensure the same commits are in the history of the 2021.3.4 release, 2022.1 release and master, the changes were merged (not squashed) into rc, and now with this PR also into beta, then beta can be merged back to master.
Merge in:
Testing strategy:
See individual PRs
Known issues with pull request:
None
Change log entries:
Included
Code Review Checklist: