Use NVDA+d for report details summary#13391
Merged
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Users should be made aware of the ability to report details
315fa90 to
b8f79d0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5 tasks
Contributor
Author
|
For Firefox fix, see PR: #13399 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
lukaszgo1
suggested changes
Feb 28, 2022
michaelDCurran
approved these changes
Mar 2, 2022
Qchristensen
approved these changes
Mar 2, 2022
Qchristensen
left a comment
Member
There was a problem hiding this comment.
(UserGuide change) looks good, great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #13380
Background
Improved support for reporting details summary: #13106
Summary of the issue:
Web authors would like to start using
aria-details, however:information about
longdesclongdescattribute is only valid on animgelement.longdescdoes not seem to be exposed in Chrome / edge, it continues to work in Firefox.longdescis deprecated, mdn advises not using it and transitioning away from current uses.longdeschas an incompatible UX with aria details. Thelongdescattribute contains a URL, the browser exposes an action, when triggered the URL is opened in a new tab. Aria details is expected to be read without leaving the page.Anyone who still relies on
longdescsupport can assign an alternative gesture.Description of how this pull request fixes the issue:
Testing strategy:
Using long-desc vs aria-details full page codepen or the same sample editor link:
Other tests:
Known issues with pull request:
Summary of aria-details can not be reported in firefox. This will be addressed separately:
Change log entries:
Changes
Code Review Checklist: