Skip to content

Report details summary with Firefox#13399

Merged
feerrenrut merged 2 commits into
masterfrom
reportDetailsFF
Mar 2, 2022
Merged

Report details summary with Firefox#13399
feerrenrut merged 2 commits into
masterfrom
reportDetailsFF

Conversation

@feerrenrut

Copy link
Copy Markdown
Contributor

Link to issue number:

#13391
#13106

Summary of the issue:

Details summary can not be reported in firefox browse mode.

Description of how this pull request fixes the issue:

Firefox does not yet expose the IA2 attribute "details-roles", used a proxy / optimization for fetching details relations.
The absence of this prevented the details summary being fetched.
Instead, use the existence of details relations to confirm.

Testing strategy:

Using code pen - editor or code pen - fullpage
Manual testing in Firefox

Known issues with pull request:

None

Change log entries:

None

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@feerrenrut feerrenrut requested a review from a team as a code owner February 28, 2022 04:09
@feerrenrut feerrenrut self-assigned this Mar 1, 2022
@feerrenrut feerrenrut requested a review from seanbudd March 1, 2022 04:46
Comment thread source/NVDAObjects/IAccessible/ia2Web.py
@feerrenrut feerrenrut merged commit 4fc0b6f into master Mar 2, 2022
@feerrenrut feerrenrut deleted the reportDetailsFF branch March 2, 2022 04:17
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants