Conversation
|
Hello Here are 4 threads on the translators mailing list regarding Bangla translation: thread 1, thread 3, thread 3, thread 4 To summarize two translators are willing to translate NVDA to Bangla/Bengali and we are continuing discussion privately to help them do the job. For now:
For now only a translated symbol file can be added to NVDA 2022.1. But with the news I have today, I doubt that the interface file will be ready. What do you suggest to do? For now, I think that Bangla has already appeared in the language list of General settings window in beta branch (to be confirmed). But the interface will be exclusively in English for now. Thanks. |
|
In addition, here are review feedbacks on this PR:
|
|
Hi, I vote to delay Bengali to 2022.2. If we caught this in say, late January, I think it would have made it to 2022.1. However, given that beta to master and master to beta exchange was declared today, I think we don’t have time to get a new language into NVDA, especially given that it will take several weeks to test the user interface fully. Folks can say that we can improve things during the beta cycle, but it is a bit risky this time since we are dealing with a year.1 beta, which puts pressure on not only translators, but also on add-ons community as well. Another option is delay beta to master merge for about a week or so in hopes that Bengali interface is in, but then it puts pressure on translators to complete their work and test the interface. Thanks.
|
|
[...]
I'm not familiar with the translations system (perhaps this was always done as you've described above) so please don't take this as a criticism but IMO introducing a template .po file into SRT until it is at least partially translated causes more trouble than it is worth. Aside from the issue that there is a new language which exists in preferences but does not contain translatable messages it just pollutes the SVN commit history unnecessarily. I tent to agree with @josephsl that the best course of action for now would be to remove the .po template from SVN and document that only partially translated files should be committed into SVN to avoid similar issues in the future. |
|
No problem for criticism. I try to do my best to drive Bangla translators since no one else had answered their messages. But that's the first time I do it, so I am opened to any remark to improve. I agree that Bangla translation should not be included in 2022.1 since it is clear that will not be mature enough for that time. At the beginning, I had thought that it would be interesting to have a working translation framework but I realize now that I should have waited a bit more. Sorry for the confusion. It should now be determined the best way to exclude Bangla translation. I think that:
If nvda.po can remain in the SRT repo, it would be better since it can help the translator to learn to use SVN. If not, no problem, let's remove it for now. Let's wait for NVAccess comments to decide how to resolve this issue. |
|
Hi, After thinking about this for a while, it appears the script used to check translation progress didn't work as intended. Normally when merging in po files from Subversion (SVN) to Git, a script will ensure that at least 70% of messages were translated (in this case, at least 1805 translated messages). Therefore, it is okay to leave bn/nvda.po in the translations workflow (SVN). As for the overall purpose of this PR: we add language codes if Windows does not support it (see #8538 for a case for Kurdish). I expect Bengali (bn) is not a supported LCID by default, so it makes sense to proceed with this PR by adding it in LCID map. However, as I noted earlier, introducing a new language just as we are exchanging data between master and beta branches is risky. This is riskier now because:
One thing I have learned as a translator and managing translations forum and workflow in general: timing and communication are very important. More importantly, willingness by translators to communicate with the community, learn about the workflow, and keeping translations updated and as accurate as possible (not just messages, but also being sensitive to cultural expectations of the local community) are important, especially considering that NVDA is promoted as a multilingual screen reader. Therefore, in light of the situation here, and since Bengali translators are new to translations workflow and contribution in general, I propose to look at the check translation script to make sure this does not happen again. Practically speaking, I would like to suggest the following actions:
As for item 4, I think it is something that translations list should have a serious discussion about (note that I'm not part of the translations list anymore). Thanks. |
Has this ever worked for translations to NVDA? Looking at scripts in mrConfig this check applies only to the translations for add-ons. I agree extending it to the .po files for NVDA is a right thing to do. |
|
Hi, yes as the check po script was originally intended for NVDA Core and later extended to cover add-ons. Thanks.
|
That's correct. I think this PR needs to be updated to be more explicit about how this is obtained.
Hopefully this should be covered in the description of the variable. Languages can be mapped to many locales (eg en_AU, en_US). This is a map of locale identifiers in Windows, to just their language code (with other parts of the locale stripped).
These items should probably be split out into We should probably avoid relying on LCIDs in future: LCID deprecation |
|
The existing work done in |
|
Hi, I think that’s a doable short-term solution. Of course the long-term solution is communicating with Bengali translators. Thanks.
|
|
Hi, as a follow-up thought: I think we might as well use this opportunity to spell out the order of things to be translated and committed. The order of precedence (as noted in “translating NVDA” document) is user interface (nvda.po) as highest of highest of priorities, followed by character descriptions and symbols, and if time permits, user guide and what’s new document, and based on feedback from the language community, add-ons. Of course we should also think about a possibility like the one we are facing at the moment (no user interface translation but we do have character descriptions and CLDR data). Thanks.
|
|
@josephsl Also, discussions surrounding translations are better suited to a separate issue/discussion or the mailing list. |
|
Hi, in that case, let’s do as proposed – keep bn interface and transfer communication with translators to translations list. Thanks.
|
|
In the beginning, I have asked bn translators (Fahim FARHAN ISHRAK and Abu Faraj ) to continue e-mail exchanges privately to set up SVN and so on since they needed very basic instructions and I did not want to clutter the list with a lot of messages, the translator mailing list being described as a low-traffic mailing list. But given our discussion here, I understand the need to have exchange with bn translators public on the translator mailing list. I will send a message to ask them to use the list instead of our private e-mail exchanges from now on. |
These weren't added by the new translations team for Bengali and therefore are out of scope here:
Introducing a new language without a single translated message is pretty illogical - for an end user who decides to switch their NVDAto Bengali it can even be perceived as a bug. |
|
Closing in favour of #13342. |
Summary of the issue: The latest PR (#13338) to merge beta to master has failed, due to Bangla translations being introduced and windowsPrimaryLCIDsToLocaleNames not listing the locale. AppVeyor build failure. On #13339, @CyrilleB79 raised that this variable is poorly documented and outdated. The initial variable provided a mapping of LCIDs to language codes, without the rest of the locale. We now normalize the locale as necessary in normalizeLanguage instead. On further inspection, it appears that the only additions from locale.windows_locale are as follows: { 1170: 'ckb', 1109: 'my', 1143: 'so', + 2117: 'bn', 9242: 'sr', } As locale.windows_locale is incomplete, these were introduced to ensure languages translated in NVDA could be mapped. Instead, the Windows function LCIDToLocaleName can be used to get each of these locales. This was suggested in #4203. However Windows maps 1170 to "ku-Arab-IQ" not "ckb", and a translation is added for Central Kurdish in localesData.LANG_NAMES_TO_LOCALIZED_DESCS["ckb"]. NVDA may drop "Arab-IQ" from this locale to get the language, losing the locality of "Central Kurdish". Description of how this pull request fixes the issue: Removes windowsPrimaryLCIDsToLocaleNames, instead use LCIDToLocaleName after checking for an internal mapping (eg for "ckb").
Link to issue number:
None
Summary of the issue:
The latest PR (#13338) to merge beta to master has failed, due to Bangla translations being introduced and NVDA not fully supporting them yet. AppVeyor build failure
Description of how this pull request fixes the issue:
Add Bangla locale to windowsPrimaryLCIDsToLocaleNames
Testing strategy:
Create a try build of beta merged into this PR: Note that both unit and system tests pass
Known issues with pull request:
None
Change log entries:
None
Code Review Checklist: