Log WindowErrors for easeOfAccess and config by seanbudd · Pull Request #13242 · nvaccess/nvda

seanbudd · 2022-01-17T06:28:13Z

Link to issue number:

Relates to #13155

Summary of the issue:

In order to investigate #13155, further logging is needed.

Description of how this pull request fixes the issue:

Adds logging for WindowErrors raised in easeOfAccess and config. This includes improvements to functions unrelated to #13155, which access the registry, by adding logging to prevent similar issues.

Testing strategy:

General alpha testing is needed to ensure the warnings and errors raised aren't noisy.
Manually test installing NVDA
Manually test toggling NVDA start after logon (both on and off)
- ensure changing the setting persists across instances
  - from the installer
  - [from an installed copy
Manually test toggling NVDA start on logon screen (both on and off)
- ensure changing the setting persists across instances
  - from the installer
  - from an installed copy
Additional testing is needed to try and reproduce Start NVDA after I sign in option is sometimes not preserved #13155, and get a clear picture of where the problem could be occurring.
- This is yet to be reliably reproduced. The following has been tested:
  - Running the installer under a profile with special characters which can cause os.stat to fail (Testé ç ş ğ).
  - Start NVDA after I sign in option is sometimes not preserved #13155 general re-attempt
    - download a copy of the installer from this PR
    - install this PR build
    - turn on "start after logon", save the config
    - create a copy of the installer from this PR, identical except with a higher build number
    - run the identical, but newer installer to cause an update to occur
    - capture the installer log
    - start the newly installed copy
    - open the settings, check if "start after logon" is enabled
    - if not, capture the latest NVDA log
    - upload both logs

Known issues with pull request:

None

Change log entries:

For Developers

- ```config.RUN_REGKEY``, ``config.NVDA_REGKEY`` are deprecated, please use ``config.RegistryKey.RUN``, ``config.RegistryKey.NVDA`` instead. These will be removed in 2023. (#13242)
- ``easeOfAccess.ROOT_KEY``, ``easeOfAccess.APP_KEY_PATH`` are deprecated, please use``easeOfAccess.RegistryKey.ROOT``, ``easeOfAccess.RegistryKey.APP`` instead. These will be removed in 2023. (#13242)
- ``easeOfAccess.APP_KEY_NAME`` has been deprecated, to be removed in 2023. (#13242)

Code Review Checklist:

Pull Request description:
- description is up to date
- change log entries
Testing:
- Unit tests
- System (end to end) tests
- Manual testing
API is compatible with existing add-ons.
Documentation:
- User Documentation
- Developer / Technical Documentation
- Context sensitive help for GUI changes
UX of all users considered:
- Speech
- Braille
- Low Vision
- Different web browsers
- Localization in other languages / culture than English

AppVeyorBot · 2022-01-17T06:44:29Z

Unable to install NVDA prior to tests.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/vrsgis82weu2kdkm/artifacts/output/nvda_snapshot_pr13242-24470,63b06a10.exe

See test results for failed build of commit 63b06a1044

AppVeyorBot · 2022-01-19T03:02:59Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests. See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/qaug6lnr2l52kmba/artifacts/output/nvda_snapshot_pr13242-24488,c80b4ceb.exe

See test results for failed build of commit c80b4ceb72

AppVeyorBot · 2022-01-19T03:34:56Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests. See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/825264cr8fqu526v/artifacts/output/nvda_snapshot_pr13242-24489,1c290c47.exe

See test results for failed build of commit 1c290c47bc

AppVeyorBot · 2022-01-19T04:37:34Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests. See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/ajn2xjspymkalj5s/artifacts/output/nvda_snapshot_pr13242-24492,b7da7b6c.exe

See test results for failed build of commit b7da7b6c48

AppVeyorBot · 2022-01-19T05:23:25Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests. See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/rcmljig830g6u6xd/artifacts/output/nvda_snapshot_pr13242-24493,b7da7b6c.exe

See test results for failed build of commit b7da7b6c48

…easeOfAccess-config

Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>

AppVeyorBot · 2022-01-30T23:29:52Z

PASS: Translation comments check.
PASS: Unit tests.
PASS: Lint check.
FAIL: System tests. See test results for more information.
Build (for testing PR): https://ci.appveyor.com/api/buildjobs/6c99vftwq0kjeav7/artifacts/output/nvda_snapshot_pr13242-24560,2cf98f73.exe

See test results for failed build of commit 2cf98f73b2

feerrenrut

Looks good @seanbudd

@Stefan-Kliesch-FHP

…creen (#13384) Fix-up of PR #13242 Originally reported by @Stefan-Kliesch-FHP in #13348 Summary of the issue: getStartOnLogonScreen can fail with UnboundLocalError when the autostart key does not exist. Description of how this pull request fixes the issue: If we failed to open autostart key we no longer try to access it.

seanbudd force-pushed the log-exceptions-for-easeOfAccess-config branch from 0244a69 to 879bca1 Compare January 19, 2022 02:48

seanbudd force-pushed the log-exceptions-for-easeOfAccess-config branch from 2635d90 to fde810b Compare January 19, 2022 04:22

seanbudd force-pushed the log-exceptions-for-easeOfAccess-config branch from fde810b to 4c8686d Compare January 20, 2022 06:02

Log exceptions for easeOfAccess and config

9ac7087

seanbudd force-pushed the log-exceptions-for-easeOfAccess-config branch from 4c8686d to 9ac7087 Compare January 20, 2022 06:16

debug log a warning when NVDA registry key not set

c453632

seanbudd requested a review from feerrenrut January 24, 2022 01:02

seanbudd marked this pull request as ready for review January 24, 2022 01:02

seanbudd requested a review from a team as a code owner January 24, 2022 01:02

seanbudd mentioned this pull request Jan 24, 2022

Start NVDA after I sign in option is sometimes not preserved #13155

Closed

Merge remote-tracking branch 'origin/master' into log-exceptions-for-…

3dbb21e

…easeOfAccess-config

feerrenrut reviewed Jan 28, 2022

View reviewed changes

Comment thread source/config/__init__.py

feerrenrut suggested changes Jan 28, 2022

View reviewed changes

Comment thread source/config/__init__.py

Comment thread source/easeOfAccess.py

Comment thread source/easeOfAccess.py Outdated

seanbudd commented Jan 28, 2022

View reviewed changes

Comment thread source/config/__init__.py Outdated

seanbudd and others added 2 commits January 28, 2022 14:53

fix typo

2cb54d5

improve comment

207910d

Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>

delay deprecations

91143ce

seanbudd requested a review from feerrenrut January 31, 2022 00:30

feerrenrut approved these changes Jan 31, 2022

View reviewed changes

seanbudd merged commit e37b9a0 into master Jan 31, 2022

seanbudd deleted the log-exceptions-for-easeOfAccess-config branch January 31, 2022 02:30

nvaccessAuto added this to the 2022.1 milestone Jan 31, 2022

seanbudd added a commit that referenced this pull request Jan 31, 2022

Add changes from #13242

263a42f

seanbudd mentioned this pull request Jan 31, 2022

Add changes from #13242 #13291

Merged

seanbudd added a commit that referenced this pull request Jan 31, 2022

Add changes from #13242 (#13291)

443bf19

lukaszgo1 mentioned this pull request Feb 23, 2022

No longer try to access non-existing registry key in getStartOnLogonScreen #13384

Merged

5 tasks

seanbudd mentioned this pull request Mar 30, 2022

Start NVDA after sign in option is sometimes not preserved when updating #8720

Open

seanbudd mentioned this pull request Feb 16, 2026

Start NVDA after I Log onto Windows: Provide additional Logging upon Failure #10667

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Log WindowErrors for easeOfAccess and config#13242

Log WindowErrors for easeOfAccess and config#13242
seanbudd merged 6 commits into
masterfrom
log-exceptions-for-easeOfAccess-config

seanbudd commented Jan 17, 2022 •

edited

Loading

Uh oh!

AppVeyorBot commented Jan 17, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Jan 30, 2022

Uh oh!

feerrenrut left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

seanbudd commented Jan 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing strategy:

Known issues with pull request:

Change log entries:

Code Review Checklist:

Uh oh!

AppVeyorBot commented Jan 17, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

AppVeyorBot commented Jan 19, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AppVeyorBot commented Jan 30, 2022

Uh oh!

feerrenrut left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

seanbudd commented Jan 17, 2022 •

edited

Loading