Skip to content

No longer try to access non-existing registry key in getStartOnLogonScreen#13384

Merged
seanbudd merged 2 commits into
nvaccess:masterfrom
lukaszgo1:noUnboundLocalErrorIngetStartOnLogonScreen
Feb 23, 2022
Merged

No longer try to access non-existing registry key in getStartOnLogonScreen#13384
seanbudd merged 2 commits into
nvaccess:masterfrom
lukaszgo1:noUnboundLocalErrorIngetStartOnLogonScreen

Conversation

@lukaszgo1

@lukaszgo1 lukaszgo1 commented Feb 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of PR #13242
Originally reported by @Stefan-Kliesch-FHP in #13348

Summary of the issue:

getStartOnLogonScreen can fail with UnboundLocalError when the autostart key does not exist.

Description of how this pull request fixes the issue:

If we failed to open autostart key we no longer try to access it.

Testing strategy:

This is pretty hard to test, but based on the exception from this comment I'm pretty confident about this fix.

Known issues with pull request:

None known

Change log entries:

None needed - unreleased regression.

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner February 23, 2022 11:59
@lukaszgo1 lukaszgo1 requested a review from seanbudd February 23, 2022 11:59
@lukaszgo1

lukaszgo1 commented Feb 23, 2022

Copy link
Copy Markdown
Contributor Author

This should be added to 2022.1 milestone.

@AppVeyorBot

AppVeyorBot commented Feb 23, 2022

Copy link
Copy Markdown

See test results for failed build of commit 761b8a1582

seanbudd
seanbudd approved these changes Feb 23, 2022
View reviewed changes

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukaszgo1

@seanbudd seanbudd merged commit 3b08819 into nvaccess:master Feb 23, 2022
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Feb 23, 2022
@lukaszgo1 lukaszgo1 deleted the noUnboundLocalErrorIngetStartOnLogonScreen branch February 23, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2022.1

Development

Successfully merging this pull request may close these issues.

4 participants

@lukaszgo1 @AppVeyorBot @seanbudd @nvaccessAuto