Add a script to report locationText for the position of the system caret#13060
Merged
Conversation
…report location of the caret and move reporting of review cursor location into a separate script.
seanbudd
requested changes
Nov 15, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks @lukaszgo1, generally looks good to me. I've added a few whitespace and other minor fixes.
Contributor
Author
|
@seanbudd I believe all changes you've requested are now addressed. |
seanbudd
approved these changes
Nov 16, 2021
seanbudd
left a comment
Member
There was a problem hiding this comment.
Thanks @lukaszgo1, looks good to me.
Going to wait for @Qchristensen to check the user guide changes before merging.
5 tasks
michaelDCurran
pushed a commit
that referenced
this pull request
Dec 6, 2021
Punctuation in the descriptions of the new scripts added in PR #13060 was used inconsistently i.e. missing full stops and commas. Description of how this pull request fixes the issue: Fixed these inconsistencies by making sure that all full sentences ends with a full stop and added a missing comma.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #9147
Related to #7314
Summary of the issue:
Currently it is impossible to report locationText for the current caret position only for the position of the review cursor. This is problematic in several cases:
While for people working with review cursor following system caret current NVDA+Numpad delete is sufficient for these use cases when review cursor does not follow caret you need to move it to focus every time when you need to check your current position which wastes time, and more importantly makes your review position lost.
Description of how this pull request fixes the issue:
Testing strategy:
Ensured that modified scripts works.
Known issues with pull request:
None known
Change log entries:
Changes
Code Review Checklist: