Skip to content

Fix-up of PR 13060: Make punctuation in the descriptions of scripts more consistent#13137

Merged
michaelDCurran merged 1 commit into
nvaccess:masterfrom
lukaszgo1:PR13060Fix-upConsistentPunctuationInScriptDescriptions
Dec 6, 2021
Merged

Fix-up of PR 13060: Make punctuation in the descriptions of scripts more consistent#13137
michaelDCurran merged 1 commit into
nvaccess:masterfrom
lukaszgo1:PR13060Fix-upConsistentPunctuationInScriptDescriptions

Conversation

@lukaszgo1

Copy link
Copy Markdown
Contributor

Link to issue number:

Fix-up of PR #13060

Summary of the issue:

Punctuation in the descriptions of the new scripts added in PR #13060 was used inconsistently i.e. missing full stops and commas.

Description of how this pull request fixes the issue:

Fixed these inconsistencies by making sure that all full sentences ends with a full stop and added a missing comma.

Testing strategy:

Double checked descriptions of these scripts.

Known issues with pull request:

None known

Change log entries:

None needed

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English

@lukaszgo1 lukaszgo1 requested a review from a team as a code owner December 6, 2021 12:07
@michaelDCurran michaelDCurran merged commit 257a6e9 into nvaccess:master Dec 6, 2021
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Dec 6, 2021
@lukaszgo1 lukaszgo1 deleted the PR13060Fix-upConsistentPunctuationInScriptDescriptions branch December 6, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants