Skip to content

Add support for the VisioBraille Vario 4 Braille Device#12607

Merged
seanbudd merged 4 commits into
nvaccess:masterfrom
Tobias-Team-Visiobraille:patch-2
Aug 4, 2021
Merged

Add support for the VisioBraille Vario 4 Braille Device#12607
seanbudd merged 4 commits into
nvaccess:masterfrom
Tobias-Team-Visiobraille:patch-2

Conversation

@Tobias-Team-Visiobraille

@Tobias-Team-Visiobraille Tobias-Team-Visiobraille commented Jul 2, 2021 •
edited by seanbudd
Loading

Copy link
Copy Markdown
Contributor

Link to issue number:

None

Summary of the issue:

Set new PID for the Vario 4 series

Description of how this pull request fixes the issue:

want to build 3 length of the Vario 4 20 40 80 because the device tell the screenreader the length while connection
we need only need one new PID

Testing strategy:

Manual testing

Build (for testing PR): https://ci.appveyor.com/api/buildjobs/0djn47pgvabr30ut/artifacts/output/nvda_snapshot_pr12607-23270,2d86e96c.exe

Known issues with pull request:

None

Change log entries:

New features

- Add support for the VisioBraille Vario 4 Braille Device. (#12607)

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

@Tobias-Team-Visiobraille Tobias-Team-Visiobraille requested a review from a team as a code owner July 2, 2021 14:19
@Tobias-Team-Visiobraille

Tobias-Team-Visiobraille commented Jul 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@ the first commit the VID wasn´t correcht 0904 is right...the Alias VisioBraille should be used is that possible? @michaelDCurran

@AppVeyorBot

AppVeyorBot commented Jul 2, 2021

Copy link
Copy Markdown

See test results for failed build of commit 2d86e96cae

@XLTechie

XLTechie commented Jul 2, 2021 via email

Copy link
Copy Markdown
Collaborator

@seanbudd seanbudd marked this pull request as draft July 5, 2021 01:51
@seanbudd

seanbudd commented Jul 5, 2021

Copy link
Copy Markdown
Member

I've converted this to a draft, let us know when the template has been filled out and this is ready for review.

@feerrenrut

feerrenrut commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

On first inspection this looks like a duplicate of #12606, however the "VID" (vender ID) is different VID_0483 vs VID_0904 in #12606 vs #12607 respectively.

The only information given at the top of #12606 is:

Want to insert our new Braille line "Vario 4" 6301 the lenght will be communicate after connection is esthablished. Hope this works with BT too.

Since these two PR's are so similar, I'm going to close #12606.
@Tobias-Team-Visiobraille we'll need more information and confirmation of testing results before we can include this change.

@feerrenrut feerrenrut mentioned this pull request Jul 21, 2021
Closed
8 tasks
@seanbudd seanbudd marked this pull request as ready for review July 26, 2021 01:26
seanbudd
seanbudd requested changes Jul 26, 2021
View reviewed changes

@seanbudd seanbudd left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the title and the PR description.

You can test that this works using the build link you have added to the Pull Request description.

This pull request is currently targeting master, likely to be included in the 2021.3 release, if you wish this to be included in 2021.2 please test this and update the target branch for this request to beta.

the Alias VisioBraille should be used is that possible?

Is this something that is also blocking the request from being merged?

Comment thread source/bdDetect.py Outdated
@seanbudd seanbudd changed the title Update bdDetect.py Add support for the VisioBraille Vario 4 Braille Device Jul 26, 2021
@seanbudd seanbudd merged commit f61c3f1 into nvaccess:master Aug 4, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Aug 4, 2021
@Tobias-Team-Visiobraille

Tobias-Team-Visiobraille commented Aug 6, 2021

Copy link
Copy Markdown
Contributor Author

Hello Sean, is there any possibility to include the Vario 4 device support into Update 2021.2 instead of 2021.3?
Thanks Tobias

@Dirk-Team-VisioBraille

Dirk-Team-VisioBraille commented Apr 21, 2022

Copy link
Copy Markdown

Hello Sean,
this is Dirk from the VisioBraille Team. Since Tobias left the company its my job to organize the integration of the Braille displays into the screenreaders. I'm no software guy at all and I don't know how to manage this. Can you pleas help me?

What do I have to do for the integration of the Vario464 and the Vario480?

Many thanks in advance for helping me.
Dirk

@Dirk-Team-VisioBraille

Dirk-Team-VisioBraille commented Apr 27, 2022

Copy link
Copy Markdown

@seanbudd
Can you please help me?
Kind regards
Dirk

@seanbudd

seanbudd commented Apr 27, 2022

Copy link
Copy Markdown
Member

@Dirk-Team-VisioBraille

Hi Dirk,
This is a fairly complicated request. I'd like to avoid discussing this on an unrelated pull request. Please send an email to info@nvaccess.org.

@Dirk-Team-VisioBraille

Dirk-Team-VisioBraille commented Apr 28, 2022

Copy link
Copy Markdown

Thanks for responding. I sent a mail for you to info@nvaccess.org. Will you respond it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seanbudd seanbudd seanbudd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2021.3

Development

Successfully merging this pull request may close these issues.

7 participants

@Tobias-Team-Visiobraille @AppVeyorBot @XLTechie @seanbudd @feerrenrut @Dirk-Team-VisioBraille @nvaccessAuto