Skip to content

Update bdDetect.py#12606

Closed
Tobias-Team-Visiobraille wants to merge 1 commit into
nvaccess:masterfrom
Tobias-Team-Visiobraille:patch-1
Closed

Update bdDetect.py#12606
Tobias-Team-Visiobraille wants to merge 1 commit into
nvaccess:masterfrom
Tobias-Team-Visiobraille:patch-1

Conversation

@Tobias-Team-Visiobraille

@Tobias-Team-Visiobraille Tobias-Team-Visiobraille commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

Want to insert our new Braille line "Vario 4" 6301 the lenght will be communicate after connection is esthablished. Hope this works with BT too.

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing strategy:

Known issues with pull request:

Change log entries:

New features
Changes
Bug fixes
For Developers

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual testing.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers

Want to insert our new Braille line "Vario 4" 6301 the lenght will be communicate after connection is esthablished. Hope this works with BT too.
@AppVeyorBot

Copy link
Copy Markdown

See test results for failed build of commit 819ff2c478

@seanbudd seanbudd marked this pull request as draft July 5, 2021 01:53
@seanbudd

seanbudd commented Jul 5, 2021

Copy link
Copy Markdown
Member

I've converted this to a draft, let us know when the template has been filled out, tests are passing and this is ready for review.

@feerrenrut

Copy link
Copy Markdown
Contributor

This seems to duplicate the intent of #12607, I'm closing this PR in favor of #12607. For more info see: #12607 (comment)

@feerrenrut feerrenrut closed this Jul 21, 2021
@Tobias-Team-Visiobraille

Tobias-Team-Visiobraille commented Jul 23, 2021 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants