Report if an object has details in browseMode#12439
Merged
Merged
Conversation
seanbudd
commented
May 21, 2021
Collaborator
|
Reef Turner wrote:
I think this is fine. Personally I think that "marked content has details" reads better than "has details marked content". Might be good to get a few more
opinions.
Agreed. Imo the former flows more smoothly.
|
6 tasks
feerrenrut
added a commit
that referenced
this pull request
Jan 10, 2022
Summary: Follows from #12439 Reporting "has details" and summarizing the details was not supported in focus mode or content editable. Description of change: - Adds system tests for focus mode / content editable - Exposes an in-process approach to summarize an IAccessible getTextFromIAccessible moved from ia2LiveRegions.cpp to textFromIAccessible.h/cpp and exposed as nvdaInProcUtils_getTextFromIAccessible via IA2Support.cpp - Now it is easier to fetch the details relation targets from python code. - Updates reporting of has details and details summary to work in both browse and focus mode. Known issues: Currently only a single relation can be summarized. Support for multiple details relations will be added later, there are various UX concerns that will need to be resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
#12364 added a command to read the summary of the aria-details. To know whether or not an object has details, this should be reported. However, new users might not want to use this feature so #12409 added a config setting to opt-in.
Description of how this pull request fixes the issue:
Discards the "has details" state change message unless the annotations config option is turned on.
Testing strategy:
Chrome system tests have been added.
Manual testing should be done in firefox using the test sample.
Known issues with pull request:
None
Change log entries:
New features (under annotations)
Code Review Checklist: