Add unmapped command to read a summary of aria-details#12364
Merged
Conversation
See test results for failed build of commit b874b786bb |
See test results for failed build of commit 00c9d557b7 |
Collaborator
|
Are most users likely to even know that aria-details exist, or that they
should access them?
Is there any indicator that aria-details are available?
|
Contributor
|
@XLTechie This is part of a much bigger block of work, which we intend to incrementally add support for. |
feerrenrut
reviewed
May 5, 2021
feerrenrut
reviewed
May 5, 2021
Collaborator
|
Ah I see, thanks.
|
03a81be to
0ea85b1
Compare
0ea85b1 to
df3f8e7
Compare
See test results for failed build of commit 4b3d75fdb5 |
lukaszgo1
reviewed
May 5, 2021
See test results for failed build of commit 0c8809c773 |
a8b165f to
44927c2
Compare
feerrenrut
suggested changes
May 11, 2021
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Generally looks good. Take care with the C++ suggestions, please verify before relying on them, it seems easy to make mistakes with BSTR: https://docs.microsoft.com/en-us/cpp/atl/programming-with-ccombstr-atl?view=msvc-160
feerrenrut
suggested changes
May 13, 2021
feerrenrut
approved these changes
May 14, 2021
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. Assuming you have tested this in firefox and chrome again since your changes?
Lets talk about a merging strategy for this on Monday.
7 tasks
seanbudd
added a commit
that referenced
this pull request
May 26, 2021
#12364 added a command to read the summary of the aria-details. To know whether or not an object has details, this should be reported. However, new users might not want to use this feature so #12409 added a config setting to opt-in. Description of how this pull request fixes the issue: Discards the "has details" state change message unless the annotations config option is turned on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
aria-detailsis a HTML attribute that contains a reference to a HTML element that contains structured details.https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Annotations#aria-details_versus_aria-describedby
It would be helpful for NVDA users to be able to read a summary of
aria-detailsbefore having to navigate through the structured annotation.Description of how this pull request fixes the issue:
Adds an unmapped command to read a summary of
aria-details.Testing strategy:
System tests that read an example from chrome are implemented.
Known issues with pull request:
None
Change log entries:
New Feature
aria-details. (Add unmapped command to read a summary of aria-details #12364)Code Review Checklist: