Allow UIA to work again on Win7 after pr #12210 by michaelDCurran · Pull Request #12233 · nvaccess/nvda

michaelDCurran · 2021-03-26T00:34:37Z

Link to issue number:

Fixes #12227

Summary of the issue:

With the merging of pr #12210 it became impossible to interact with UI Automation controls on Windows 7.

Fetching the annotationTypes UIA property raises a COMError if not implemented by the control. On newer Operating Systems UIA core returns a default.
Fetching the SelectionPattern2 interface also causes a COMError on older Operating Systems if not implemented by the control.

Description of how this pull request fixes the issue:

Catch COMError when fetching UIA annotationTypes.
Catch COMError when fetching the UIA SelectionPattern2 interface.

Testing strategy:

On Windows 10, With UIA in Excel turned on in NVDA's Advanced settings, interacted with the Excel test spreadsheet on pr #12210, confirming that all properties still read.

Get confirmation from a Win7 user that steps in Impossible to use any UIA control in latest Alpha #12227 now work.

Known issues with pull request:

None.

Change log entry:

None needed.

Code Review Checklist:

This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x: [ ] becomes [x].
You can also check the checkboxes after the PR is created.

…tionTypes UIA property, as an exception may be raised on Windows 7.

michaelDCurran · 2021-03-26T00:35:32Z

@lukaszgo1 could you please confirm this pr solves the issue for you?

lukaszgo1 · 2021-03-26T00:42:06Z

Unfortunately it does not. The traceback is different though"

error executing event: gainFocus on <NVDAObjects.Dynamic_UIItemListItemUIA object at 0x06C2F898> with extra args of {}
Traceback (most recent call last):
  File "eventHandler.py", line 246, in executeEvent
    _EventExecuter(eventName,obj,kwargs)
  File "eventHandler.py", line 96, in __init__
    self.next()
  File "eventHandler.py", line 105, in next
    return func(*args, **self.kwargs)
  File "appModules\explorer.py", line 415, in event_gainFocus
    nextHandler()
  File "eventHandler.py", line 105, in next
    return func(*args, **self.kwargs)
  File "NVDAObjects\UIA\__init__.py", line 1142, in event_gainFocus
    super().event_gainFocus()
  File "NVDAObjects\__init__.py", line 1137, in event_gainFocus
    self.reportFocus()
  File "NVDAObjects\__init__.py", line 1005, in reportFocus
    speech.speakObject(self, reason=controlTypes.OutputReason.FOCUS)
  File "speech\__init__.py", line 449, in speakObject
    sequence = getObjectSpeech(
  File "speech\__init__.py", line 491, in getObjectSpeech
    sequence = getObjectPropertiesSpeech(
  File "speech\__init__.py", line 405, in getObjectPropertiesSpeech
    and obj.selectionContainer
  File "baseObject.py", line 42, in __get__
    return instance._getPropertyViaCache(self.fget)
  File "baseObject.py", line 146, in _getPropertyViaCache
    val=getterMethod(self)
  File "NVDAObjects\UIA\__init__.py", line 1218, in _get_selectionContainer
    if obj.UIASelectionPattern2:
  File "baseObject.py", line 42, in __get__
    return instance._getPropertyViaCache(self.fget)
  File "baseObject.py", line 146, in _getPropertyViaCache
    val=getterMethod(self)
  File "NVDAObjects\UIA\__init__.py", line 1196, in _get_UIASelectionPattern2
    self.UIASelectionPattern2 = self._getUIAPattern(
  File "NVDAObjects\UIA\__init__.py", line 1168, in _getUIAPattern
    punk=self.UIAElement.GetCachedPattern(ID) if cache else self.UIAElement.GetCurrentPattern(ID)
  File "comtypesMonkeyPatches.py", line 27, in __call__
    return super().__call__(*args,**kwargs)
_ctypes.COMError: (-2147024809, 'A parameter is incorrect', (None, None, None, 0, None))

…as on Windows 7.

feerrenrut

Code changes look fine to me, pending confirmation from users that this is fixed.

The unit test / systemtest checkboxes are empty. Do you have some plans for this? It would be great to introduce system tests with office, but I think that is much too big to do off the back of this bug fix.

michaelDCurran · 2021-03-26T05:30:19Z

@lukaszgo1 are there any further errors after annotationTypes and selectionPattern2 exceptions have been handled?

lukaszgo1 · 2021-03-26T09:07:16Z

@michaelDCurran No, everything works as it should. Thanks.

Brian1Gaff · 2021-03-26T11:04:50Z

Could any of these things becausing the very strange effects of reading the main message window of the modified outlook express that runs on windows 7? Its a bit all over the place with inability to read at the start but in sayall reads a bit from down the page then jumps back to the start and reads that, then the rest of the message on latest alpha. In my view nothing should be screwed up until support for 7 ends. Brian ***@***.*** Sent via blueyonder. Please address personal E-mail to:- ***@***.***, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Michael Curran" ***@***.***> To: "nvaccess/nvda" ***@***.***> Cc: "Subscribed" ***@***.***> Sent: Friday, March 26, 2021 5:30 AM Subject: Re: [nvaccess/nvda] Allow UIA to work again on Win7 after pr #12210 (#12233)

…

@lukaszgo1 are there any further errors after annotationTypes and selectionPattern2 exceptions have been handled? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #12233 (comment)

michaelDCurran · 2021-03-26T11:07:35Z

It would be very helpful if you could try various alpha snapshots and let us know which was the first one where it broke. what you are describing was certainly not expected.

lukaszgo1 · 2021-03-26T11:33:43Z

@Brian1Gaff could you please test with https://ci.appveyor.com/api/buildjobs/w86gtxym7utyec7v/artifacts/output%2Fnvda_snapshot_pr12228-22161%2C2c4361c6.exe
If the problem does not occur with that build pr #12228 would fix this.

Brian1Gaff · 2021-03-27T09:25:07Z

Yes that looks good. For the record it was also affecting a notepad replacement I had as well, and a few other oddities, which I have not got around to investigating as yet. Brian ***@***.*** Sent via blueyonder. Please address personal E-mail to:- ***@***.***, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Łukasz Golonka" ***@***.***> To: "nvaccess/nvda" ***@***.***> Cc: "Brian Gaff" ***@***.***>; "Mention" ***@***.***> Sent: Friday, March 26, 2021 11:33 AM Subject: Re: [nvaccess/nvda] Allow UIA to work again on Win7 after pr #12210 (#12233)

…

@Brian1Gaff could you please test with https://ci.appveyor.com/api/buildjobs/w86gtxym7utyec7v/artifacts/output%2Fnvda_snapshot_pr12228-22161%2C2c4361c6.exe If the problem does not occur with that build pr #12228 would fix this. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #12233 (comment)

Brian1Gaff · 2021-03-27T09:27:13Z

One oddity that did occur while installing was that it bleped twice during the first install then lost the pull down menu reading, but a restart of that version has fixed it. Unfortunately its overwritten the old log now, sorry. My brain is not as agile as it used to be! Brian ***@***.*** Sent via blueyonder. Please address personal E-mail to:- ***@***.***, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Łukasz Golonka" ***@***.***> To: "nvaccess/nvda" ***@***.***> Cc: "Brian Gaff" ***@***.***>; "Mention" ***@***.***> Sent: Friday, March 26, 2021 11:33 AM Subject: Re: [nvaccess/nvda] Allow UIA to work again on Win7 after pr #12210 (#12233)

…

@Brian1Gaff could you please test with https://ci.appveyor.com/api/buildjobs/w86gtxym7utyec7v/artifacts/output%2Fnvda_snapshot_pr12228-22161%2C2c4361c6.exe If the problem does not occur with that build pr #12228 would fix this. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #12233 (comment)

Brian1Gaff · 2021-03-27T09:36:18Z

I occasionally get this error when moving between folders, IO - inputCore.InputManager.executeGesture (09:27:15.788) - winInputHook (3640): Input: kb(desktop):enter IO - speech.speak (09:27:15.811) - MainThread (5056): Speaking [LangChangeCommand ('en_GB'), '4 nvda issues list - Outlook Express - Brians lists account BGlists', CancellableSpeech (still valid)] ERROR - eventHandler.executeEvent (09:27:17.421) - MainThread (5056): error executing event: gainFocus on <appModules.msimn.MessageListItem object at 0x06158B38> with extra args of {} Traceback (most recent call last): File "eventHandler.pyc", line 246, in executeEvent File "eventHandler.pyc", line 96, in __init__ File "eventHandler.pyc", line 105, in next File "C:\nvda extra\userConfig\addons\applicationDictionary\globalPlugins\applicationDictionary.py", line 85, in event_gainFocus nextHandler() File "eventHandler.pyc", line 105, in next File "appModules\msimn.pyc", line 80, in event_gainFocus File "eventHandler.pyc", line 105, in next File "NVDAObjects\__init__.pyc", line 1137, in event_gainFocus File "NVDAObjects\behaviors.pyc", line 580, in reportFocus File "NVDAObjects\__init__.pyc", line 1005, in reportFocus File "speech\__init__.pyc", line 449, in speakObject File "speech\__init__.pyc", line 491, in getObjectSpeech File "speech\__init__.pyc", line 355, in getObjectPropertiesSpeech File "baseObject.pyc", line 42, in __get__ File "baseObject.pyc", line 146, in _getPropertyViaCache File "appModules\msimn.pyc", line 128, in _get_name File "baseObject.pyc", line 42, in __get__ File "baseObject.pyc", line 146, in _getPropertyViaCache File "NVDAObjects\IAccessible\sysListView32.pyc", line 451, in _get_name File "NVDAObjects\IAccessible\sysListView32.pyc", line 357, in _getColumnLocation File "baseObject.pyc", line 42, in __get__ File "baseObject.pyc", line 146, in _getPropertyViaCache File "NVDAObjects\IAccessible\sysListView32.pyc", line 220, in _get__columnOrderArray File "winKernel.pyc", line 191, in virtualAllocEx OSError: [WinError 6] The handle is invalid. IO - speech.speak (09:27:17.522) - MainThread (5056): Speaking [LangChangeCommand ('en_GB'), 'Outlook Express Message List', 'list', CancellableSpeech (still valid)] IO - speech.speak (09:27:17.526) - MainThread (5056): Speaking [LangChangeCommand ('en_GB'), 'unread has attachment; From: NV Access Git; Subject: nvda/master 656ecb5: Allow UIA to work again on Win7 after pr #12210 (#12233); Received: 26/03/2021 10:53', '1896 of 1896', CancellableSpeech (still valid)] Not sure what that is all about. Brian ***@***.*** Sent via blueyonder. Please address personal E-mail to:- ***@***.***, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Łukasz Golonka" ***@***.***> To: "nvaccess/nvda" ***@***.***> Cc: "Brian Gaff" ***@***.***>; "Mention" ***@***.***> Sent: Friday, March 26, 2021 11:33 AM Subject: Re: [nvaccess/nvda] Allow UIA to work again on Win7 after pr #12210 (#12233)

…

@Brian1Gaff could you please test with https://ci.appveyor.com/api/buildjobs/w86gtxym7utyec7v/artifacts/output%2Fnvda_snapshot_pr12228-22161%2C2c4361c6.exe If the problem does not occur with that build pr #12228 would fix this. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #12233 (comment)

Brian1Gaff · 2021-03-28T09:39:31Z

I have also tried it with some notepad replacements as well and they seem back to normal also. Pretty weird and unexpected effect, so I think we are good to go if others have no other issues. Brian ***@***.*** Sent via blueyonder. Please address personal E-mail to:- ***@***.***, putting 'Brian Gaff' in the display name field. Newsgroup monitored: alt.comp.blind-users ----- Original Message ----- From: "Łukasz Golonka" ***@***.***> To: "nvaccess/nvda" ***@***.***> Cc: "Brian Gaff" ***@***.***>; "Mention" ***@***.***> Sent: Friday, March 26, 2021 12:33 PM Subject: Re: [nvaccess/nvda] Allow UIA to work again on Win7 after pr #12210 (#12233)

…

@Brian1Gaff could you please test with https://ci.appveyor.com/api/buildjobs/w86gtxym7utyec7v/artifacts/output%2Fnvda_snapshot_pr12228-22161%2C2c4361c6.exe If the problem does not occur with that build pr #12228 would fix this. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: #12233 (comment)

UIA NVDAObject's states property: catch COMError when fetching annota…

2ef2eed

…tionTypes UIA property, as an exception may be raised on Windows 7.

michaelDCurran requested a review from seanbudd March 26, 2021 00:34

UIA NVDAObject's UIASelectionPattern2 property: catch COMError, such …

e6d49b1

…as on Windows 7.

feerrenrut reviewed Mar 26, 2021

View reviewed changes

Comment thread source/NVDAObjects/UIA/__init__.py Outdated

Address review actions

ea82d47

feerrenrut approved these changes Mar 26, 2021

View reviewed changes

michaelDCurran merged commit 656ecb5 into master Mar 26, 2021

michaelDCurran deleted the i12227 branch March 26, 2021 10:52

nvaccessAuto added this to the 2021.1 milestone Mar 26, 2021

Uh oh!

Conversation

michaelDCurran commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link to issue number:

Summary of the issue:

Description of how this pull request fixes the issue:

Testing strategy:

Known issues with pull request:

Change log entry:

Code Review Checklist:

Uh oh!

michaelDCurran commented Mar 26, 2021

Uh oh!

lukaszgo1 commented Mar 26, 2021

Uh oh!

Uh oh!

feerrenrut left a comment

Choose a reason for hiding this comment

Uh oh!

michaelDCurran commented Mar 26, 2021

Uh oh!

lukaszgo1 commented Mar 26, 2021

Uh oh!

Brian1Gaff commented Mar 26, 2021 via email

Uh oh!

michaelDCurran commented Mar 26, 2021 via email

Uh oh!

lukaszgo1 commented Mar 26, 2021

Uh oh!

Brian1Gaff commented Mar 27, 2021 via email

Uh oh!

Brian1Gaff commented Mar 27, 2021 via email

Uh oh!

Brian1Gaff commented Mar 27, 2021 via email

Uh oh!

Brian1Gaff commented Mar 28, 2021 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

michaelDCurran commented Mar 26, 2021 •

edited

Loading