Fix-up of PR 12195: Properly reset say all when cancelling speech#12228
Merged
Conversation
Contributor
Author
|
cc @ABuffEr |
…uses` which has been used for say all.
8 tasks
Contributor
Author
|
cc @michaelDCurran @feerrenrut @seanbudd I'd be great not to forget this for 2021.1. |
Contributor
|
Yes, please prioritize this. I've been running into this bug a lot! |
Contributor
I agree. Despite what I said in #12225, this issue affects not only browsers, so it's very annoying when reading. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #12225
Summary of the issue:
PR #12195 removed
speech.speakWithoutPauseswhich was an alias forspeech._speakWithoutPauses. While all usages ofspeech.speakWithoutPauseswere found and fixed it turned out than when cancelling speech during say allspeech._speakWithoutPauseswas cleared rather than instance ofSpeakWithoutPausesused for say all.Description of how this pull request fixes the issue:
Now the instance of
SpeechWithoutPauseswhich is used during say all is cleared. I've added function tosayAllHandlerwhich creates it first if necessary, and ensures that the single instance is being used for say all.Testing strategy:
I've ensured that say all no longer mixes content from different runs.
Known issues with pull request:
None known
Change log entry:
None needed: bug not in a release.
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.