Fix regressions from #10919#10932
Merged
feerrenrut merged 4 commits intoApr 3, 2020
Merged
Conversation
Contributor
Author
josephsl
approved these changes
Apr 2, 2020
josephsl
left a comment
Contributor
There was a problem hiding this comment.
Thanks - seems to be fixed although we may need to keep an eye on more places where new formatting keys might become an issue.
feerrenrut
reviewed
Apr 2, 2020
See test results for failed build of commit cf7ed06cc8 |
feerrenrut
pushed a commit
that referenced
this pull request
May 4, 2020
In the Powerpoint appModule, the incorrect config key was used. Looking up reportSuperscriptAndSubscript (instead of the correct reportSuperscriptsAndSubscripts) resulted in an error, making certain functions unusable. Config option introduced in: "Separate the reporting of superscripts and subscripts from the report font attributes setting #10919" Regression introduced with: #10932 Fixes #11094.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #10931.
Summary of the issue:
Description of how this pull request fixes the issue:
reportSuperscriptsAndSubscriptskey to theformatConfigin_reportFormattingHelper.Testing performed:
Tested that NVDA+f is now functional.
Known issues with pull request:
None.
Change log entry:
None.