Fix Powerpoint: reportSuperscriptAndSubscript error#11095
Merged
Conversation
Contributor
Author
cc759a7 to
2c52ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #11094.
Summary of the issue:
In the Powerpoint appModule, the incorrect config key was used. Looking up
reportSuperscriptAndSubscript(instead of the correctreportSuperscriptsAndSubscripts) resulted in an error, making certain functions unusable.Config option introduced in: "Separate the reporting of superscripts and subscripts from the report font attributes setting #10919"
Regression introduced with: #10932
Description of how this pull request fixes the issue:
Uses the proper config key.
Testing performed:
Checked that the singular version didn't appear anywhere else in NVDA's source tree.
Known issues with pull request:
Change log entry:
None.