Word 365: ignore UIA notification events seen after performing various editing functions#10857
Merged
Merged
Conversation
…10851. In recent Word 365 releases, UIA notification events are fired by Word document object when editing functions are performed such as 'delete back word' being announced when Control+Backspace is pressed. Thus ignore these messages.
LeonarddeR
previously requested changes
Mar 9, 2020
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
I"m afraid this will also kill useful notifications, such as when someone starts collaborating with you on a document
Contributor
Author
|
Hi, true, hence the quick fix for now. I’m sure we can filter them out based on activity ID. Thanks.
|
…ements. Re nvaccess#10851. Reviewed by Leonard de Ruijter: there are messages in Word 365 that are announced using UIA notification. Therefore only suppress delete messages (activity ID: AccSN2).
feerrenrut
reviewed
Mar 27, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
I have tested this and confirmed that "delete back word" is no longer reported. I did not test that other UIA notifications are still reported.
@josephsl Could you comment on any testing you have done to that effect?
Contributor
Author
|
Hi, I used Windows 10 App Essentials add-on/debug output mode to confirm that: the activity ID we are looking for is indeed the ones that should be silenced, and other operations such as cut/copy/paste are announced as expected. This also works without the add-on present (source code copy). Thanks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10851
Summary of the issue:
In Word 365, word document UIA object fires UIA notification events after editing functions are performed. For example, NVDA will say "delete back word" when Control+Backspace is pressed.
Description of how this pull request fixes the issue:
Added a "dummy" UIA notification event handler in NVDAObjects.UIA.wordDocument.WordDocument class that simply returns, thus making NVDA ignore UIA notification events.
Testing performed:
Tested with Word 365, NVDA source code, and a somewhat limited fix in Windows 10 App Essentials add-on.
Known issues with pull request:
None
Change log entry:
Bug fixes:
In recent releases of Microsoft Word 365, NVDA will no longer announce "delete back word" when Control+Backspace is pressed while editing a document.