IA2: Do not treat huge base64 data as NVDA might freeze in Google Chrome (#10227) - Py2 backport to beta#10240
Conversation
|
As I feel the other pr is not yet complete, and there is no public real-life testcase to point to, and we really want to get 2019.2.1 out soon, I think I need to refuse this pr sorry. |
Review action nvaccess#10231 (comment)
|
@michaelDCurran I understand the schedule for 2019.2.1 is a matter of importance. I agree the proposed fix is not fully satisfactory as it misses the Gecko vbufBackend impact you mentioned in #10231 (comment) I'll try to work asap on the Gecko vbufBackend side, but I have other obligations towards my customers. Thus, this complementary part of the fix won't for sure be ready for 2019.2.1 |
|
thank you for the testcase, that helps a great deal. I will take a look at it tomorrow, then I can better feel the actual impact. |
|
Thank you for your time and consideration. |
… Google Chrome (PR nvaccess#10240) Ensure to truncate base64 data only in the `src` attribute, and not in an eventual text content (eg. in and inline editor). Re: nvaccess#10231 (comment)
… Google Chrome (PR #10240) (#10282) * Fix up of: IA2: Do not treat huge base64 data as NVDA might freeze in Google Chrome (PR #10240) Ensure to truncate base64 data only in the `src` attribute, and not in an eventual text content (eg. in and inline editor). Re: #10231 (comment) * Fix up of bd35387: Include the comma after "base64" in the capturing group
Link to issue number:
Issue #10227
Backport of #10231 into beta
Summary of the issue:
Huge base64 embedded in the
srcattribute of a focusableimgelement can freeze Google Chrome.Description of how this pull request fixes the issue:
When the IA2 attribute string exceeds a threshold of 4096 characters, truncate the base64 from the text passed to
IAccessibleHandler.splitIA2Attribsbefore treating it.Testing performed:
Known issues with pull request:
The huge base64 is still uselessly present in the Virtual Buffer data.
The NVDAHelper thus would probably benefit from an impact on that regard.
Change log entry:
Section: Bug fixes
NVDA no longer crashes in Google Chrome when an image contains huge base64 data.