Fix up of: IA2: Do not treat huge base64 data as NVDA might freeze in Google Chrome (PR #10240)#10282
Conversation
… Google Chrome (PR nvaccess#10240) Ensure to truncate base64 data only in the `src` attribute, and not in an eventual text content (eg. in and inline editor). Re: nvaccess#10231 (comment)
The current pr has exceeded the version range of 2019.2.1 |
Indeed, as clarified by @michaelDCurran in 19486b0 this change is worthwhile in master but there is no critical misbehavior in the current implementation, so I guess we won't take the risk of an emergency fix into beta. Thanks |
Link to issue number:
Fix up of PR #10240
Backport of fix up #10281 into beta
Summary of the issue:
As mentioned by @michaelDCurran in #10231 (comment)
IAccessibleHandler.splitIA2Attribsmight also receive IAccessibleText as argument.Description of how this pull request fixes the issue:
Alter the regex as to ensure to truncate base64 data only in the
srcattribute, and not in an eventualtext content (eg. in and inline editor).
Testing performed:
Tested against the test case of #10227.
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes