Hide the mouse when screen curtain is on#10182
Merged
Merged
Conversation
feerrenrut
approved these changes
Sep 10, 2019
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
I have tested this PR, and could not see the mouse cursor when screen curtain was active.
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Sep 13, 2019
Only hide the mouse when screen curtain effectively turned on. This prevents the mouse to disappear if the screen curtain could no be turned on because the Windows Magnifier is started.
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Sep 13, 2019
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Sep 13, 2019
michaelDCurran
pushed a commit
that referenced
this pull request
Sep 17, 2019
* Fix up of: Hide the mouse when screen curtain is on (PR #10182) Only hide the mouse when screen curtain effectively turned on. This prevents the mouse to disappear if the screen curtain could no be turned on because the Windows Magnifier is started. * Fix up of: Hide the mouse when screen curtain is on (PR #10182) Review action #10211 (comment) * Fix up of: Hide the mouse when screen curtain is on (PR #10182) Review action #10211 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #10181
Summary of the issue:
When the screen curtain is on, the mouse is still visible.
Description of how this pull request fixes the issue:
Use the MagShowSystemCursor function to hide the mouse. Also call the particular function with a True boolean value when terminating, though I think that's not strictly necessary.
@feerrenrut: may be you could quickly check this when reviewing this?
Testing performed:
Asked a sighted person to verify that the mouse is now gone.
Known issues with pull request:
None
Change log entry:
None