Fix up of: Hide the mouse when screen curtain is on (PR #10182)#10211
Merged
michaelDCurran merged 3 commits intoSep 17, 2019
Merged
Conversation
Only hide the mouse when screen curtain effectively turned on. This prevents the mouse to disappear if the screen curtain could no be turned on because the Windows Magnifier is started.
LeonarddeR
suggested changes
Sep 13, 2019
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Good catch, thanks @JulienCochuyt
LeonarddeR
reviewed
Sep 13, 2019
| try: | ||
| super(VisionEnhancementProvider, self).terminate() | ||
| Magnification.MagUninitialize() | ||
| except: # noqa: E722 |
Collaborator
There was a problem hiding this comment.
These two lines don't have to be there. not specifying an except in a try/finally will just raise.
Having said that, the only exception I expect is Windows Error.
LeonarddeR
approved these changes
Sep 13, 2019
1 task
michaelDCurran
approved these changes
Sep 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only hide the mouse when screen curtain effectively turned on.
This prevents the mouse to disappear if the screen curtain could no be turned
on because the Windows Magnifier is started.
Link to issue number:
Fix up of PR #9982
Summary of the issue:
If the Windows Magnifier is on, Screen Curtain fails to turn on but the mouse is hidden.
To show the mouse again, one has to turn Windows Magnifier off then turn Screen Curtain on and off then turn Windows Magnifier back on.
Description of how this pull request fixes the issue:
Hide the mouse only when Screen Curtain effectively turned on.
Testing performed:
Checked the mouse is not hidden if Screen Curtain failed to turn on.
Checked the mouse is hidden if Screen Curtain succeeded to turn on.
Checked the mouse is shown again when Screen Curtain is turned off.
Known issues with pull request:
Change log entry:
N/A