ExitDialog: Align OK and Cancel buttons to the right#10076
Merged
feerrenrut merged 1 commit intoOct 19, 2019
Conversation
Contributor
Contributor
Author
|
@feerrenrut did you have the time to have a look to this PR? If you require some changes on my side, please let me know. |
feerrenrut
approved these changes
Oct 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Improves #6468.
Summary of the issue:
Unlike in most NVDA dialogs, the OK and Cancel buttons of the exit dialog are left aligned.
Description of how this pull request fixes the issue:
Those two buttons have been aligned to the right so that this dialog looks like all other Windows and NVDA ones.
Testing performed:
Simply closed NVDA and verified that the visual appearance of the dialog was correct.
Known issues with pull request:
None.
Change log entry:
None needed.